pptp-linux: bump to version 1.8.0
PATCH v2 1/1 pptp-linux: bump to version 1.8.0
---
.../pptp-linux/pptp-linux-001-susv3-legacy.patch | 43 +++++++++++----------
.../pptp-linux/pptp-linux-002-drop-stropts.patch | 26 -------------
...tch => pptp-linux-002-fix-parallel-build.patch} | 0
package/pptp-linux/pptp-linux-003-ip-path.patch | 44 ----------------------
package/pptp-linux/pptp-linux.mk | 5 ++-
5 files changed, 27 insertions(+), 91 deletions(-)
delete mode 100644 package/pptp-linux/pptp-linux-002-drop-stropts.patch
rename package/pptp-linux/{pptp-linux-004-fix-parallel-build.patch => pptp-linux-002-fix-parallel-build.patch} (100%)
delete mode 100644 package/pptp-linux/pptp-linux-003-ip-path.patchpackage/pptp-linux/pptp-linux-001-susv3-legacy.patch +24 -19
@@ -1,24 +1,29 @@ -diff -rdup pptp-linux-1.7.0/pptp_callmgr.c pptp-linux-1.7.0.orig/pptp_callmgr.c ---- pptp-linux-1.7.0/pptp_callmgr.c 2005-07-28 03:15:11.000000000 +0200 -+++ pptp-linux-1.7.0.orig/pptp_callmgr.c 2007-08-24 09:20:39.000000000 +0200 -@@ -314,7 +314,7 @@ int open_inetsock(struct in_addr inetadd - return s; +bzero is deprecated in POSIX.1-2001 and removed for POSIX.1-2008 so +switch to memset instead. + +Signed-off-by: Gustavo Zacarias <[email protected]> + +diff -Nura pptp-1.8.0.orig/pptp_callmgr.c pptp-1.8.0/pptp_callmgr.c +--- pptp-1.8.0.orig/pptp_callmgr.c 2013-10-23 05:10:46.000000000 -0300 ++++ pptp-1.8.0/pptp_callmgr.c 2014-03-31 16:47:42.617643298 -0300 +@@ -340,7 +340,7 @@ } + #endif if (localbind.s_addr != INADDR_NONE) { - bzero(&src, sizeof(src)); -+ memset(&src, 0, sizeof(src)); - src.sin_family = AF_INET; - src.sin_addr = localbind; - if (bind(s, (struct sockaddr *) &src, sizeof(src)) != 0) { -diff -rdup pptp-linux-1.7.0/pptp_gre.c pptp-linux-1.7.0.orig/pptp_gre.c ---- pptp-linux-1.7.0/pptp_gre.c 2005-07-28 03:15:11.000000000 +0200 -+++ pptp-linux-1.7.0.orig/pptp_gre.c 2007-08-24 09:20:56.000000000 +0200 -@@ -81,7 +81,7 @@ int pptp_gre_bind(struct in_addr inetadd - int s = socket(AF_INET, SOCK_RAW, PPTP_PROTO); - if (s < 0) { warn("socket: %s", strerror(errno)); return -1; } ++ memset(&src, 0, sizeof(src)); + src.i.sin_family = AF_INET; + src.i.sin_addr = localbind; + if (bind(s, &src.a, sizeof(src.i)) != 0) { +diff -Nura pptp-1.8.0.orig/pptp_gre.c pptp-1.8.0/pptp_gre.c +--- pptp-1.8.0.orig/pptp_gre.c 2013-10-23 05:10:46.000000000 -0300 ++++ pptp-1.8.0/pptp_gre.c 2014-03-31 16:47:30.745249066 -0300 +@@ -103,7 +103,7 @@ + } + #endif if (localbind.s_addr != INADDR_NONE) { - bzero(&loc_addr, sizeof(loc_addr)); -+ memset(&loc_addr, 0, sizeof(loc_addr)); - loc_addr.sin_family = AF_INET; - loc_addr.sin_addr = localbind; - if (bind(s, (struct sockaddr *) &loc_addr, sizeof(loc_addr)) != 0) { ++ memset(&loc_addr, 0, sizeof(loc_addr)); + loc_addr.i.sin_family = AF_INET; + loc_addr.i.sin_addr = localbind; + if (bind(s, &loc_addr.a, sizeof(loc_addr.i)) != 0) {
package/pptp-linux/pptp-linux-002-drop-stropts.patch deleted +0 -26
@@ -1,26 +0,0 @@ -From ae214f5103dfaa92ecb0b1953d4c9dd059e620ca Mon Sep 17 00:00:00 2001 -From: Gustavo Zacarias <[email protected]> -Date: Thu, 21 Oct 2010 10:59:02 -0300 -Subject: [PATCH] Drop stropts.h, it's deprecated and unneeded - - -Signed-off-by: Gustavo Zacarias <[email protected]> ---- - pptp_compat.c | 1 - - 1 files changed, 0 insertions(+), 1 deletions(-) - -diff --git a/pptp_compat.c b/pptp_compat.c -index 1760a3b..e98cbf0 100644 ---- a/pptp_compat.c -+++ b/pptp_compat.c -@@ -7,7 +7,6 @@ - #include <fcntl.h> - #include <sys/types.h> - #include <unistd.h> --#include <stropts.h> - #include <stdlib.h> - #include <strings.h> - #include "pptp_compat.h" --- -1.7.2.2 -
package/pptp-linux/pptp-linux-002-fix-parallel-build.patch renamed from package/pptp-linux/pptp-linux-004-fix-parallel-build.patch +0 -0
package/pptp-linux/pptp-linux-003-ip-path.patch deleted +0 -44
44 lines not on this page · raw message
package/pptp-linux/pptp-linux.mk +3 -2
@@ -4,7 +4,7 @@ # ################################################################################ -PPTP_LINUX_VERSION = 1.7.2 +PPTP_LINUX_VERSION = 1.8.0 PPTP_LINUX_SITE = http://downloads.sourceforge.net/project/pptpclient/pptp/pptp-$(PPTP_LINUX_VERSION) PPTP_LINUX_SOURCE = pptp-$(PPTP_LINUX_VERSION).tar.gz PPTP_LINUX_MAKE = $(MAKE1)
@@ -15,7 +15,8 @@ define PPTP_LINUX_BUILD_CMDS $(MAKE) -C $(@D) OPTIMIZE= DEBUG= \ CC="$(TARGET_CC)" \ CFLAGS="$(TARGET_CFLAGS)" \ - LDFLAGS="$(TARGET_LDFLAGS)" + LDFLAGS="$(TARGET_LDFLAGS)" \ + IP=/sbin/ip endef define PPTP_LINUX_INSTALL_TARGET_CMDS
Signature · 1 line
1.8.3.2
Thomas Petazzoni
AppliedPATCH v2 1/1 pptp-linux: bump to version 1.8.0
Dear Gustavo Zacarias,
Quoted 11 lines · Gustavo Zacarias
Signed-off-by Gustavo Zacarias <[email protected]>--- .../pptp-linux/pptp-linux-001-susv3-legacy.patch | 43 +++++++++++---------- .../pptp-linux/pptp-linux-002-drop-stropts.patch | 26 ------------- ...tch => pptp-linux-002-fix-parallel-build.patch} | 0 package/pptp-linux/pptp-linux-003-ip-path.patch | 44 ---------------------- package/pptp-linux/pptp-linux.mk | 5 ++- 5 files changed, 27 insertions(+), 91 deletions(-) delete mode 100644 package/pptp-linux/pptp-linux-002-drop-stropts.patch rename package/pptp-linux/{pptp-linux-004-fix-parallel-build.patch => pptp-linux-002-fix-parallel-build.patch} (100%) delete mode 100644 package/pptp-linux/pptp-linux-003-ip-path.patch
Applied, thanks.
Would however be good to have a small changelog when you send two consecutive versions, as well as more details about the updates in the patches when they are non-trivial as is the case here.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 pptp-linux: bump to version 1.8.0
In reply to Gustavo ZacariasDear Gustavo Zacarias,
Quoted 11 lines · Gustavo Zacarias
Signed-off-by Gustavo Zacarias <[email protected]>--- .../pptp-linux/pptp-linux-001-susv3-legacy.patch | 43 +++++++++++---------- .../pptp-linux/pptp-linux-002-drop-stropts.patch | 26 ------------- ...tch => pptp-linux-002-fix-parallel-build.patch} | 0 package/pptp-linux/pptp-linux-003-ip-path.patch | 44 ---------------------- package/pptp-linux/pptp-linux.mk | 5 ++- 5 files changed, 27 insertions(+), 91 deletions(-) delete mode 100644 package/pptp-linux/pptp-linux-002-drop-stropts.patch rename package/pptp-linux/{pptp-linux-004-fix-parallel-build.patch => pptp-linux-002-fix-parallel-build.patch} (100%) delete mode 100644 package/pptp-linux/pptp-linux-003-ip-path.patch
Seems to break the build on ARM:
http://autobuild.buildroot.org/results/5bd/5bdfcf544a83e18d12e27c598084c0ad520d6164/build-end.log
{standard input}: Assembler messages:
{standard input}:225: Error: bad instruction rorw $8,' {standard input}:225: Error: bad instruction rorl $16,r2' {standard input}:225: Error: bad instruction `rorw $8,'
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 pptp-linux: bump to version 1.8.0
Quoted 15 lines · Thomas Petazzoni
Dear Gustavo Zacarias,
Quoted 11 lines · Gustavo Zacarias
Signed-off-by Gustavo Zacarias <[email protected]>--- .../pptp-linux/pptp-linux-001-susv3-legacy.patch | 43 +++++++++++---------- .../pptp-linux/pptp-linux-002-drop-stropts.patch | 26 ------------- ...tch => pptp-linux-002-fix-parallel-build.patch} | 0 package/pptp-linux/pptp-linux-003-ip-path.patch | 44 ---------------------- package/pptp-linux/pptp-linux.mk | 5 ++- 5 files changed, 27 insertions(+), 91 deletions(-) delete mode 100644 package/pptp-linux/pptp-linux-002-drop-stropts.patch rename package/pptp-linux/{pptp-linux-004-fix-parallel-build.patch => pptp-linux-002-fix-parallel-build.patch} (100%) delete mode 100644 package/pptp-linux/pptp-linux-003-ip-path.patch
Quoted 8 lines
Seems to break the build on ARM:
http://autobuild.buildroot.org/results/5bd/5bdfcf544a83e18d12e27c598084c0ad520d6164/build-end.log
{standard input}: Assembler messages:
{standard input}:225: Error: bad instructionrorw $8,' {standard input}:225: Error: bad instructionrorl $16,r2' {standard input}:225: Error: bad instruction `rorw $8,'
That's ptpd2 and not pptp-linux, hopefully pppd won't show up in the mix for a triple tongue twister ;)
Seems a distribution net-snmp is polluting the build, it should be fixed by the patch i've sent, but i couldn't reproduce the failure locally. Regards.