drm/i915: vlv: fix RPS interrupt mask setting
Subsystems (2)
PATCH 1/1 drm/i915: vlv: fix RPS interrupt mask setting
This typo may lead to missed RPS interrupts and as a result a too low or too high frequency for the current workload. The interrupt mask will be set properly at a subsequent GPU idle event, but can get corrupted again at the next RPS up/down event.
--- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +1 -1
@@ -3159,7 +3159,7 @@ void valleyview_set_rps(struct drm_device *dev, u8 val)if (val != dev_priv->rps.cur_freq)vlv_punit_write (dev_priv,PUNIT_REG_GPU_FREQ_REQ , val); -I915_WRITE (GEN6_PMINTRMSK , val); +I915_WRITE (GEN6_PMINTRMSK ,gen6_rps_pm_mask (dev_priv, val)); dev_priv->rps.cur_freq = val;trace_intel_gpu_freq_change (vlv_gpu_freq (dev_priv, val));
Signature · 1 line
1.8.4
Quoted 6 lines · Imre Deak
This typo may lead to missed RPS interrupts and as a result a too low or too high frequency for the current workload. The interrupt mask will be set properly at a subsequent GPU idle event, but can get corrupted again at the next RPS up/down event.
Signed-off-by Imre Deak <[email protected]>
Embarrassing. Really odd as I thought I just cut'n'paste that line.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Daniel Vetter
AppliedQuoted 10 lines · Chris Wilson
Quoted 6 lines · Imre Deak
This typo may lead to missed RPS interrupts and as a result a too low or too high frequency for the current workload. The interrupt mask will be set properly at a subsequent GPU idle event, but can get corrupted again at the next RPS up/down event.
Signed-off-by Imre Deak <[email protected]>Embarrassing. Really odd as I thought I just cut'n'paste that line.
Reviewed-by Chris Wilson <[email protected]>
Picked up for -fixes, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch