Skip to contentSkip to conversation

network-manager: Don't build Qt example programs

PATCH New Vicente Olivert Riera 3 participants 3 messages Apr 4, 2014

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/1 network-manager: Don't build Qt example programs

The purpose of "--enable-qt" option is not to build NetworkManager with Qt support. It's name can be a bit confusing. The real purpose of this option is to build Qt example programs, so we disable it as we also disable the tests and documentation in the target.

Fixes:
http://autobuild.buildroot.net/results/3b6/3b6a40c1683d0859a934e4d79e2048e97b193e94/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/network-manager/network-manager.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/network-manager/network-manager.mk +1 -0
index 24bae63..1953888 100644
@@ -24,6 +24,7 @@ NETWORK_MANAGER_CONF_ENV = \
 NETWORK_MANAGER_CONF_OPT = \
 		--mandir=$(STAGING_DIR)/usr/man/ \
 		--disable-tests \
+		--disable-qt \
 		--disable-more-warnings \
 		--without-docs \
 		--disable-gtk-doc \
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 network-manager: Don't build Qt example programs

Quoted 18 lines · Vicente Olivert Riera

The purpose of "--enable-qt" option is not to build NetworkManager with Qt support. It's name can be a bit confusing. The real purpose of this option is to build Qt example programs, so we disable it as we also disable the tests and documentation in the target.

Fixes:

   http://autobuild.buildroot.net/results/3b6/3b6a40c1683d0859a934e4d79e2048e97b193e94/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/network-manager/network-manager.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/network-manager/network-manager.mk +0 -0
index 24bae63..1953888 100644

package/network-manager/network-manager.mk NETWORK_MANAGER_CONF_ENV = \ · line 30

Quoted 7 lines
package/network-manager/network-manager.mk +1 -0
@@ -24,6 +24,7 @@ NETWORK_MANAGER_CONF_ENV = \
 NETWORK_MANAGER_CONF_OPT = \
                --mandir=$(STAGING_DIR)/usr/man/ \
                --disable-tests \
+               --disable-qt \
                --disable-more-warnings \
                --without-docs \
                --disable-gtk-doc \
Tested-by Yegor Yefremov <[email protected]>
Applied
#2 lore raw

PATCH 1/1 network-manager: Don't build Qt example programs

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 5 lines · Vicente Olivert Riera

The purpose of "--enable-qt" option is not to build NetworkManager with Qt support. It's name can be a bit confusing. The real purpose of this option is to build Qt example programs, so we disable it as we also disable the tests and documentation in the target.

Quoted 7 lines

Fixes:

   http://autobuild.buildroot.net/results/3b6/3b6a40c1683d0859a934e4d79e2048e97b193e94/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/network-manager/network-manager.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com