gitk: switch to patch mode when searching for line origin
PATCH 1/1 gitk: switch to patch mode when searching for line origin
If the "Show origin of this line" is started from tree mode, it still shows the result in tree mode, which I suppose not what user expects to see.
--- gitk | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
gitk +6 -2
@@ -3870,7 +3870,7 @@ proc read_line_source {fd inst} { set id $nullid2 } if {[commitinview $id $curview]} { - selectline [rowofcommit $id] 1 [list $fname $lnum] + selectline [rowofcommit $id] 1 [list $fname $lnum] 1 } else { error_popup [mc "That line comes from commit %s, \ which is not in this view" [shortids $id]]
@@ -7161,7 +7161,7 @@ proc make_idmark {id} { $canv raise $t } -proc selectline {l isnew {desired_loc {}}} { +proc selectline {l isnew {desired_loc {}} {switch_to_patch 0}} { global canv ctext commitinfo selectedline global canvy0 linespc parents children curview global currentid sha1entry
@@ -7187,6 +7187,10 @@ proc selectline {l isnew {desired_loc {}}} { setcanvscroll } + if {$cmitmode ne "patch" && $switch_to_patch} { + set cmitmode "patch" + } + set y [expr {$canvy0 + $l * $linespc}] set ymax [lindex [$canv cget -scrollregion] 3] set ytop [expr {$y - $linespc - 1}]
Signature · 1 line
1.8.5.2.421.g4cdf8d0
Paul Mackerras
AppliedQuoted 3 lines · Max Kirillov
If the "Show origin of this line" is started from tree mode, it still shows the result in tree mode, which I suppose not what user expects to see.
Thanks, applied.
Paul.