Skip to contentSkip to conversation

libuci: fix Lua finding

PATCH New Yegor Yefremov 2 participants 2 messages Apr 5, 2014 – Apr 6, 2014

lore
Share & tools
lore

Yegor Yefremov

author
#0 lore raw

PATCH 1/1 libuci: fix Lua finding

This patch fixes Lua path comparison, if Lua is not provided.

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/libuci/libuci-01-uci-fix-Lua-finding.patch | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/libuci/libuci-01-uci-fix-Lua-finding.patch
package/libuci/libuci-01-uci-fix-Lua-finding.patch new file +31 -0
new file mode 100644
index 0000000..f37e136
@@ -0,0 +1,31 @@
+From 980432ce260020ed8a907b3bbc1334845ba4c4a9 Mon Sep 17 00:00:00 2001
+From: Yegor Yefremov <[email protected]>
+Date: Sat, 5 Apr 2014 19:18:10 +0200
+Subject: [PATCH] uci: fix Lua finding
+
+If ${LUAPATH} is not quoted and Lua is not provided, then following
+error occurs:
+
+"NOT" "No such file or directory" "EQUAL" "0" "OR" "EQUAL" ""
+
+Signed-off-by: Yegor Yefremov <[email protected]>
+---
+ lua/CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lua/CMakeLists.txt b/lua/CMakeLists.txt
+index e4295d7..4ba8e37 100644
+--- a/lua/CMakeLists.txt
++++ b/lua/CMakeLists.txt
+@@ -36,7 +36,7 @@ IF(NOT LUAPATH)
+ 	)
+ 
+ 	IF(BUILD_LUA)
+-		IF(NOT ${LUA_CHECK_RES} EQUAL 0 OR ${LUAPATH} EQUAL "")
++		IF(NOT ${LUA_CHECK_RES} EQUAL 0 OR "${LUAPATH}" EQUAL "")
+ 			MESSAGE(SEND_ERROR "Lua was not found on your system")
+ 		ENDIF()
+ 	ENDIF()
+-- 
+1.8.3.2
+
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 libuci: fix Lua finding

Dear Yegor Yefremov,

Quoted 7 lines · Yegor Yefremov

This patch fixes Lua path comparison, if Lua is not provided.

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/libuci/libuci-01-uci-fix-Lua-finding.patch | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/libuci/libuci-01-uci-fix-Lua-finding.patch

Applied, thanks. I've added the autobuilder link, it would be good to do it next time, as it's very useful when looking at a commit, to get a reference to the build failure it is fixing. As an added bonus, it ensures that you are counted as the contributors fixing autobuilder failures that are thanked in the Buildroot release e-mail from Peter! :-)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com