Skip to contentSkip to conversation

support/check-kernel-headers: use mktemp instead of hand-crafted temp file

PATCH New Yann E. MORIN 2 participants 2 messages Apr 6, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/check-kernel-headers: use mktemp instead of hand-crafted temp file

From: "Yann E. MORIN" <[email protected]>

Instead of creating a temporary files with a dubious scheme, use mktemp, which purpose is exactly that: creating temporary files

---
Changes v1 -> v2:
- no space after '(' or before ')' (Thomas)

---
 support/scripts/check-kernel-headers.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/scripts/check-kernel-headers.sh +1 -1
index b511a08..2a0a301 100755
@@ -8,7 +8,7 @@ HDR_M="${HDR_VER%%.*}"
 HDR_V="${HDR_VER#*.}"
 HDR_m="${HDR_V%%.*}"
 
-EXEC="/tmp/br.check-headers.$(uuidgen)"
+EXEC="$(mktemp --tmpdir check-headers.XXXXXX)"
 
 # By the time we get here, we do not always have the staging-dir
 # already populated (think external toolchain), so we can not use
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 support/check-kernel-headers: use mktemp instead of hand-crafted temp file

Dear Yann E. MORIN,

Quoted 8 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

Instead of creating a temporary files with a dubious scheme, use mktemp, which purpose is exactly that: creating temporary files

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com