Skip to contentSkip to conversation

spi: efm32: Make "efm32,location" property optional

PATCH In review Axel Lin 2 participants 2 messages Apr 7, 2014

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 spi: efm32: Make "efm32,location" property optional

If "efm32,location" property is not provided, keeping what is already configured in the hardware, so its either the reset default 0 or whatever the bootloader did.

---
 Documentation/devicetree/bindings/spi/efm32-spi.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/spi/efm32-spi.txt +2 -0
index 8f081c9..33e6040 100644
@@ -8,6 +8,8 @@ Required properties:
 - interrupts: pair specifying rx and tx irq
 - clocks: phandle to the spi clock
 - cs-gpios: see spi-bus.txt
+
+Recommended properties :
 - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
 
 Example:
Signature · 8 lines
1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw

Hello,

the Subject still suggests a change in the driver.

Quoted 3 lines · Axel Lin

If "efm32,location" property is not provided, keeping what is already configured in the hardware, so its either the reset default 0 or whatever the bootloader did.

I would prefer to have this info in the binding doc.

Best regards
Uwe

Quoted 24 lines
---
 Documentation/devicetree/bindings/spi/efm32-spi.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/spi/efm32-spi.txt +2 -0
index 8f081c9..33e6040 100644
@@ -8,6 +8,8 @@ Required properties:
 - interrupts: pair specifying rx and tx irq
 - clocks: phandle to the spi clock
 - cs-gpios: see spi-bus.txt
+
+Recommended properties :
 - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
 
 Example:
Signature · 1 line
1.8.3.2
Signature · 6 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html