SCSI_MLQUEUE_EH_RETRY?

DISCUSSION Christoph Hellwig 1 participant 1 message Apr 7, 2014 SCSI

Share & tools

Christoph Hellwig

author

2014-04-07 14:39 UTC #0 lore raw

While the comments and code structure in scsi_io_completion suggest that calling __scsi_queue_insert with SCSI_MLQUEUE_EH_RETRY has a different effect from using SCSI_MLQUEUE_DEVICE_BUSY they are treated exactly the same.

It seems like when SCSI_MLQUEUE_EH_RETRY was introduced it didn't set device_blocked, but since commit 573e5913536a1393362265cfea9e708aa10fdf16 "[SCSI] scsi_lib: pause between error retries" they are one and the same.

Is there any point in keeping SCSI_MLQUEUE_EH_RETRY?