Skip to contentSkip to conversation

latencytop: disable static build

PATCH New Baruch Siach 2 participants 3 messages Apr 7, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 latencytop: disable static build

The Makefile of latencytop doesn't take static linking into account when calling pkg-config for glib-2.0. Disable static build of latencytop.

Fixes:
http://autobuild.buildroot.net/results/e62/e62d35bcf7d6c98d0a0348532c2b159affb20e83/

---
 package/latencytop/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/latencytop/Config.in +4 -2
index b54ef052b47f..9d6e119fa759 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LATENCYTOP
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # libglib2
+	depends on !BR2_PREFER_STATIC_LIB
 	select BR2_PACKAGE_NCURSES
 	select BR2_PACKAGE_LIBGLIB2
 	help
@@ -21,6 +22,7 @@ config BR2_PACKAGE_LATENCYTOP
 
 	  http://www.latencytop.org
 
-comment "latencytop needs a toolchain w/ wchar, threads"
+comment "latencytop needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_PREFER_STATIC_LIB
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 latencytop: disable static build

Dear Baruch Siach,

Quoted 2 lines · Baruch Siach

The Makefile of latencytop doesn't take static linking into account when calling pkg-config for glib-2.0. Disable static build of latencytop.

Well, there are *lots* of packages that don't take into account static linking with pkg-config. There is even a patch proposed to improve this
situation: http://patchwork.ozlabs.org/patch/326741/.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 latencytop: disable static build

Hi Thomas,

Quoted 7 lines · Thomas Petazzoni
Quoted 2 lines · Baruch Siach

The Makefile of latencytop doesn't take static linking into account when calling pkg-config for glib-2.0. Disable static build of latencytop.

Well, there are *lots* of packages that don't take into account static linking with pkg-config. There is even a patch proposed to improve this
situation: http://patchwork.ozlabs.org/patch/326741/.

Thanks for the tip. I'll test this patch and report.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -