phylib: export phy_suspend and phy_resume
Subsystems (3)
PATCH 1/1 phylib: export phy_suspend and phy_resume
These functions are exported in include/linux/phy.h but the symbol exports where missing.
--- drivers/net/phy/phy_device.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/phy/phy_device.c +2 -0
@@ -695,6 +695,7 @@ int phy_suspend(struct phy_device *phydev)return phydrv->suspend (phydev);return 0 ; } +EXPORT_SYMBOL (phy_suspend);int phy_resume (struct phy_device *phydev) {
@@ -704,6 +705,7 @@ int phy_resume(struct phy_device *phydev)return phydrv->resume (phydev);return 0 ; } +EXPORT_SYMBOL (phy_resume);/* Generic PHY support and helper functions */
Signature · 1 line
1.8.4.357.g8d83871.dirty
2014-04-08 0:11 GMT-07:00 Tobias Waldekranz <[email protected]>:
Quoted 2 lines
These functions are exported in
include/linux/phy.hbut the symbol exports where missing.
Thanks! I had this sitting somewhere and somehow forgot to send it.
Quoted 2 lines
Signed-off-by Tobias Waldekranz <[email protected]>
Quoted 31 lines
--- drivers/net/phy/phy_device.c | 2 ++ 1 file changed, 2 insertions(+)drivers/net/phy/phy_device.c +2
-1@@ -695,6 +695,7 @@ int phy_suspend(struct phy_device *phydev)return phydrv->suspend (phydev);return 0 ; } +EXPORT_SYMBOL (phy_suspend);int phy_resume (struct phy_device *phydev) {@@ -704,6 +705,7 @@ int phy_resume(struct phy_device *phydev)return phydrv->resume (phydev);return 0 ; } +EXPORT_SYMBOL (phy_resume);/* Generic PHY support and helper functions */ --1.8.4.357.g8d83871.dirty
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Florian
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Tue, 8 Apr 2014 08:26:39 -0700
Quoted 10 lines
2014-04-08 0:11 GMT-07:00 Tobias Waldekranz <[email protected]>:
Quoted 2 lines
These functions are exported in
include/linux/phy.hbut the symbol exports where missing.Thanks! I had this sitting somewhere and somehow forgot to send it.
Quoted 2 lines
Signed-off-by Tobias Waldekranz <[email protected]>Acked-by Florian Fainelli <[email protected]>
I don't want to see these exported until there is an actual use.
David Miller
maintainerFrom: Tobias Waldekranz <[email protected]>
Date: Tue, 8 Apr 2014 09:11:01 +0200
Quoted 4 lines
These functions are exported in
include/linux/phy.hbut the symbol exports where missing.Signed-off-by Tobias Waldekranz <[email protected]>
Because they are only used in places where module exports are unnecessary. Presence in foo.h does not automatically mean the symbol should be exported to modules.
If you come up with a use case that requires the module export, submit it along with a patch like this.
But for now I'm not applying this, sorry.
Quoted 8 lines · David Miller
From: Tobias Waldekranz <[email protected]>
Date: Tue, 8 Apr 2014 09:11:01 +0200Quoted 4 lines
These functions are exported in
include/linux/phy.hbut the symbol exports where missing.Signed-off-by Tobias Waldekranz <[email protected]>
Quoted 8 lines
Because they are only used in places where module exports are unnecessary. Presence in
foo.hdoes not automatically mean the symbol should be exported to modules.If you come up with a use case that requires the module export, submit it along with a patch like this.
But for now I'm not applying this, sorry.
Further investigation revealed that I was actually looking for phy_start/stop. Sorry about the noise.
Signature · 2 lines
Thanks - wkz