spi: qup: Depend on ARCH_QCOM
Subsystems (2)
PATCH 1/1 spi: qup: Depend on ARCH_QCOM
Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit left one (optional) dependency on ARCH_MSM_DT untouched.
Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60, ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.
---
Untested!
Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it appears to make sense to pick ARCH_QCOM here.
drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
@@ -383,7 +383,7 @@ config SPI_RSPI config SPI_QUP tristate "Qualcomm SPI controller with QUP interface" - depends on ARCH_MSM_DT || (ARM && COMPILE_TEST) + depends on ARCH_QCOM || (ARM && COMPILE_TEST) help Qualcomm Universal Peripheral (QUP) core is an AHB slave that provides a common data path (an output FIFO and an input FIFO)
Signature · 6 lines
1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Brown
maintainerQuoted 7 lines · Paul Bolle
Commit
8fc1b0f87d9f("ARM: qcom: Split Qualcomm support into legacy and multiplatform") removedKconfigsymbolARCH_MSM_DT. But that commit left one (optional) dependency onARCH_MSM_DTuntouched.Three
Kconfigsymbols used to depend onARCH_MSM_DT:ARCH_MSM8X60,ARCH_MSM8960, andARCH_MSM8974. These three symbols now depend onARCH_QCOM. So it appears this driver needs to depend onARCH_QCOMtoo.
You probably want to CC some of the Qualcomm people (or whoever made the above change) who know what's going on with these symbols.
PATCH RESEND 1/1 spi: qup: Depend on ARCH_QCOM
Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit left one (optional) dependency on ARCH_MSM_DT untouched.
Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60, ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.
---
Resending, because Mark suggested to include the Qualcomm people (who know what's going on with these symbols).
Still untested!
Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it appears to make sense to pick ARCH_QCOM here.
drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
@@ -383,7 +383,7 @@ config SPI_RSPI config SPI_QUP tristate "Qualcomm SPI controller with QUP interface" - depends on ARCH_MSM_DT || (ARM && COMPILE_TEST) + depends on ARCH_QCOM || (ARM && COMPILE_TEST) help Qualcomm Universal Peripheral (QUP) core is an AHB slave that provides a common data path (an output FIFO and an input FIFO)
Signature · 1 line
1.9.0
Quoted 9 lines · Paul Bolle
Commit
8fc1b0f87d9f("ARM: qcom: Split Qualcomm support into legacy and multiplatform") removedKconfigsymbolARCH_MSM_DT. But that commit left one (optional) dependency onARCH_MSM_DTuntouched.Three
Kconfigsymbols used to depend onARCH_MSM_DT:ARCH_MSM8X60,ARCH_MSM8960, andARCH_MSM8974. These three symbols now depend onARCH_QCOM. So it appears this driver needs to depend onARCH_QCOMtoo.Signed-off-by Paul Bolle <[email protected]>
Quoted 7 lines
Resending, because Mark suggested to include the Qualcomm people (who know what's going on with these symbols).
Still untested!
Note that this is basically guesswork: looking at commit
8fc1b0f87d9fit appears to make sense to pickARCH_QCOMhere.
That's correct.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 3 lines · Paul Bolle
Commit
8fc1b0f87d9f("ARM: qcom: Split Qualcomm support into legacy and multiplatform") removedKconfigsymbolARCH_MSM_DT. But that commit left one (optional) dependency onARCH_MSM_DTuntouched.
Applied, thanks.