staging: media: omap24xx: fix up a checkpatch.pl warning
Subsystems (2)
PATCH 2/2 staging: media: omap24xx: fix up a checkpatch.pl warning
tcm825x.c:
changed printk to pr_info
--- drivers/staging/media/omap24xx/tcm825x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/omap24xx/tcm825x.c +2 -2
@@ -914,8 +914,8 @@ static int __init tcm825x_init(void) rval =i2c_add_driver (&tcm825x_i2c_driver);if (rval) -printk (KERN_INFO "%s: failed registering " TCM825X_NAME "\n" , - __func__); +pr_info ("%s: failed registering " TCM825X_NAME "\n" , + __func__);return rval; }
Signature · 1 line
1.7.9.5
The two subjects are really close to being the same. You should choose better subjects. Like:
[PATCH 2/2] staging: media: omap24xx: use pr_info() instead of KERN_INFO
(All the checkpatch.pl people use the exact same subject for everything though, so you're not alone in this).
regards,
dan carpenter
Thanks, that's helpful - I for some reason thought that multi-part patch had to have more or less uniform subject. We the checkpatch.pl people come from http://www.eudyptula-challenge.org/, where at some stage we are told to submit a patch for a single style issue in the staging tree. All newbies... Hoping to be back with more substantial contributions soon.
Regards,
Vitaly
Quoted 12 lines · Dan Carpenter
The two subjects are really close to being the same. You should choose better subjects. Like:
[PATCH 2/2] staging: media: omap24xx: use
pr_info()instead ofKERN_INFO(All the checkpatch.pl people use the exact same subject for everything though, so you're not alone in this).
regards,
dan carpenter
Quoted 6 lines · Vitaly Osipov
Thanks, that's helpful - I for some reason thought that multi-part patch had to have more or less uniform subject. We the checkpatch.pl people come from http://www.eudyptula-challenge.org/, where at some stage we are told to submit a patch for a single style issue in the staging tree. All newbies... Hoping to be back with more substantial contributions soon.
Yeah, I know about eudyptula. No worries. Newbies are welcome in staging.
regards,
dan carpenter