Skip to contentSkip to conversation

Need Clarification about Whether i can change some Specific Staging Code

DISCUSSION Kumar Gaurav 2 participants 2 messages Apr 13, 2014 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hi Greg,

I was checking drivers code to see which are still using semaphore. I found some in staging. When i opened the code for upgrading that to MUTEX i found a note. that says:

* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE!
*

  *    This is shared code between Digi's CVS archive and the
  *    Linux Kernel sources.
  *    Changing the source just for reformatting needlessly breaks
  *    our CVS diff history.

*
* Send any bug fixes/changes to: Eng.Linux at digi dot com.
* Thank you.
*/

Involved codes are
./drivers/staging/dgap/dgap_tty.c
./drivers/staging/dgnc/dgnc_tty.c

Please let me know if i can submit a patch against these files.

Regards
Kumar Gaurav

#1 lore raw
Quoted 17 lines · Kumar Gaurav

Hi Greg,

I was checking drivers code to see which are still using semaphore. I found some in staging. When i opened the code for upgrading that to MUTEX i found a note. that says:

* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE!
*

  *    This is shared code between Digi's CVS archive and the
  *    Linux Kernel sources.
  *    Changing the source just for reformatting needlessly breaks
  *    our CVS diff history.

*
* Send any bug fixes/changes to: Eng.Linux at digi dot com.
* Thank you.
*/

Quoted 5 lines

Involved codes are
./drivers/staging/dgap/dgap_tty.c
./drivers/staging/dgnc/dgnc_tty.c

Please let me know if i can submit a patch against these files.

Yes you can, in fact, you can send a patch to remove those lines :)

greg k-h