Skip to contentSkip to conversation

ARM: dts: keystone: drop address and size cells from GIC node

PATCH Superseded Lucas Stach 6 participants 13 messages Apr 11, 2014 – Apr 22, 2014

Subsystems (2)
Device tree bindings Arm/Zynq architecture

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Lucas Stach

author
#0 lore raw

PATCH 1/6 ARM: dts: keystone: drop address and size cells from GIC node

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/keystone.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/keystone.dtsi +0 -2
index 90823eb90c1b..d0b0266d8922 100644
@@ -28,8 +28,6 @@
 	gic: interrupt-controller {
 		compatible = "arm,cortex-a15-gic";
 		#interrupt-cells = <3>;
-		#size-cells = <0>;
-		#address-cells = <1>;
 		interrupt-controller;
 		reg = <0x0 0x02561000 0x0 0x1000>,
 		      <0x0 0x02562000 0x0 0x2000>,
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/6 ARM: dts: highbank, ecx-2000: drop address and size cells from GIC node

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/ecx-2000.dts | 2 --
 arch/arm/boot/dts/highbank.dts | 2 --
 2 files changed, 4 deletions(-)
arch/arm/boot/dts/ecx-2000.dts +0 -2
index 2ccbb57fbfa8..cdb7b264b7fb 100644
@@ -94,8 +94,6 @@
 		intc: interrupt-controller at fff11000 {
 			compatible = "arm,cortex-a15-gic";
 			#interrupt-cells = <3>;
-			#size-cells = <0>;
-			#address-cells = <1>;
 			interrupt-controller;
 			interrupts = <1 9 0xf04>;
 			reg = <0xfff11000 0x1000>,
arch/arm/boot/dts/highbank.dts +0 -2
index ed14aeac0566..85e1a05b8a9c 100644
@@ -109,8 +109,6 @@
 		intc: interrupt-controller at fff11000 {
 			compatible = "arm,cortex-a9-gic";
 			#interrupt-cells = <3>;
-			#size-cells = <0>;
-			#address-cells = <1>;
 			interrupt-controller;
 			reg = <0xfff11000 0x1000>,
 			      <0xfff10100 0x100>;
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 3/6 ARM: dts: zynq: drop address cells from GIC node

In reply to Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/zynq-7000.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/zynq-7000.dtsi +0 -1
index 511180769af5..3f277c2bc19c 100644
@@ -57,7 +57,6 @@
 		intc: interrupt-controller at f8f01000 {
 			compatible = "arm,cortex-a9-gic";
 			#interrupt-cells = <3>;
-			#address-cells = <1>;
 			interrupt-controller;
 			reg = <0xF8F01000 0x1000>,
 			      <0xF8F00100 0x100>;
Signature · 1 line
1.9.1
#3 lore raw

PATCH 3/6 ARM: dts: zynq: drop address cells from GIC node

Quoted 6 lines · Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Isn't this property inherited from the parent node, requiring to actually set them to 0 to comply with the docs?

Thanks,
S?ren

author
#4 lore raw

PATCH 3/6 ARM: dts: zynq: drop address cells from GIC node

Hi S?ren,

Am Freitag, den 11.04.2014, 08:54 -0700 schrieb S?ren Brinkmann:

Quoted 11 lines · Lucas Stach
Quoted 6 lines

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Isn't this property inherited from the parent node, requiring to actually set them to 0 to comply with the docs?

No, it isn't. From ePAPR v1.1 section 2.3.5:
"The #address-cells and #size-cells properties are not inherited from ancestors in the device tree. They shall be explicitly defined."

Regards,
Lucas

Signature · 4 lines
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#5 lore raw

PATCH 3/6 ARM: dts: zynq: drop address cells from GIC node

Quoted 11 lines · Lucas Stach

Hi S?ren,

Am Freitag, den 11.04.2014, 08:54 -0700 schrieb S?ren Brinkmann:

Quoted 8 lines · Lucas Stach
Quoted 6 lines

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Quoted 7 lines
Quoted 3 lines

Isn't this property inherited from the parent node, requiring to actually set them to 0 to comply with the docs?

No, it isn't. From ePAPR v1.1 section 2.3.5:
"The #address-cells and #size-cells properties are not inherited from ancestors in the device tree. They shall be explicitly defined."

Thanks, you're right. I didn't know that document yet. I have some reading to do.

S?ren

Applied
#6 lore raw

PATCH 3/6 ARM: dts: zynq: drop address cells from GIC node

In reply to Lucas Stach
Quoted 18 lines · Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/zynq-7000.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/zynq-7000.dtsi +0 -0
index 511180769af5..3f277c2bc19c 100644

arch/arm/boot/dts/zynq-7000.dtsi line 62

Quoted 7 lines
arch/arm/boot/dts/zynq-7000.dtsi +0 -1
@@ -57,7 +57,6 @@
 		intc: interrupt-controller at f8f01000 {
 			compatible = "arm,cortex-a9-gic";
 			#interrupt-cells = <3>;
-			#address-cells = <1>;
 			interrupt-controller;
 			reg = <0xF8F01000 0x1000>,
 			      <0xF8F00100 0x100>;

Applied.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140422/f86b2ed7/attachment-0001.sig>
author
#7 lore raw

PATCH 4/6 ARM: dts: vybrid: drop address and size cells from GIC node

In reply to Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/vf610.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/vf610.dtsi +0 -2
index 804873367669..bb78e901ed5d 100644
@@ -72,8 +72,6 @@
 			intc: interrupt-controller at 40002000 {
 				compatible = "arm,cortex-a9-gic";
 				#interrupt-cells = <3>;
-				#address-cells = <1>;
-				#size-cells = <1>;
 				interrupt-controller;
 				reg = <0x40003000 0x1000>,
 				      <0x40002100 0x100>;
Signature · 1 line
1.9.1
Applied
#8 lore raw

PATCH 4/6 ARM: dts: vybrid: drop address and size cells from GIC node

Quoted 8 lines · Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>

Applied, thanks.

author
#9 lore raw

PATCH 5/6 ARM: dts: ste-dbx: drop address cells from GIC node

In reply to Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/ste-dbx5x0.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/ste-dbx5x0.dtsi +0 -1
index e41eedca3ce3..c73414d3fe50 100644
@@ -24,7 +24,6 @@
 		intc: interrupt-controller at a0411000 {
 			compatible = "arm,cortex-a9-gic";
 			#interrupt-cells = <3>;
-			#address-cells = <1>;
 			interrupt-controller;
 			reg = <0xa0411000 0x1000>,
 			      <0xa0410100 0x100>;
Signature · 1 line
1.9.1
author
#10 lore raw

PATCH 6/6 ARM: dts: sh: drop address cells from GIC node

In reply to Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/r8a7740.dtsi | 1 -
 arch/arm/boot/dts/sh73a0.dtsi  | 1 -
 2 files changed, 2 deletions(-)
arch/arm/boot/dts/r8a7740.dtsi +0 -1
index 8280884bfa59..2551e9438d35 100644
@@ -28,7 +28,6 @@
 	gic: interrupt-controller at c2800000 {
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
-		#address-cells = <1>;
 		interrupt-controller;
 		reg = <0xc2800000 0x1000>,
 		      <0xc2000000 0x1000>;
arch/arm/boot/dts/sh73a0.dtsi +0 -1
index b7bd3b9a6753..5ecf552e1c00 100644
@@ -34,7 +34,6 @@
 	gic: interrupt-controller at f0001000 {
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
-		#address-cells = <1>;
 		interrupt-controller;
 		reg = <0xf0001000 0x1000>,
 		      <0xf0000100 0x100>;
Signature · 1 line
1.9.1
#11 lore raw

PATCH 6/6 ARM: dts: sh: drop address cells from GIC node

Quoted 6 lines · Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Hi Lucas,

Please split this patch into two, one for r8a7740 with the prefix
ARM: shmobile: r8a7740:

And one for sh73a0 with the prefix
ARM: shmobile: sh73a0:

Quoted 34 lines
Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/r8a7740.dtsi | 1 -
 arch/arm/boot/dts/sh73a0.dtsi  | 1 -
 2 files changed, 2 deletions(-)
arch/arm/boot/dts/r8a7740.dtsi +0 -1
index 8280884bfa59..2551e9438d35 100644
@@ -28,7 +28,6 @@
 	gic: interrupt-controller at c2800000 {
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
-		#address-cells = <1>;
 		interrupt-controller;
 		reg = <0xc2800000 0x1000>,
 		      <0xc2000000 0x1000>;
arch/arm/boot/dts/sh73a0.dtsi +0 -1
index b7bd3b9a6753..5ecf552e1c00 100644
@@ -34,7 +34,6 @@
 	gic: interrupt-controller at f0001000 {
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
-		#address-cells = <1>;
 		interrupt-controller;
 		reg = <0xf0001000 0x1000>,
 		      <0xf0000100 0x100>;
Signature · 1 line
1.9.1
maintainer
#12 lore raw

PATCH 1/6 ARM: dts: keystone: drop address and size cells from GIC node

In reply to Lucas Stach
Quoted 8 lines · Lucas Stach

This is likely a copy-and-paste error from the ARM GIC documentation, that has already been fixed.

address-cells should have been set to 0, as with the size cells. As having those properties set to 0 is the same thing as not specifying them, drop them completely.

Signed-off-by Lucas Stach <[email protected]>

Thanks for doing this. For the series:

Acked-by Rob Herring <[email protected]>

Rob

Quoted 20 lines
---
 arch/arm/boot/dts/keystone.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/keystone.dtsi +0 -3
index 90823eb90c1b..d0b0266d8922 100644
@@ -28,8 +28,6 @@
        gic: interrupt-controller {
                compatible = "arm,cortex-a15-gic";
                #interrupt-cells = <3>;
-               #size-cells = <0>;
-               #address-cells = <1>;
                interrupt-controller;
                reg = <0x0 0x02561000 0x0 0x1000>,
                      <0x0 0x02562000 0x0 0x2000>,
--

1.9.1