Skip to contentSkip to conversation

arm64:kconfig: make default for CONFIG_COMPAT

PATCH In review Chanho Min 3 participants 5 messages Apr 14, 2014 – Apr 15, 2014 arm64

lore
Share & tools
lore

Chanho Min

author
#0 lore raw

PATCH 1/1 arm64:kconfig: make default for CONFIG_COMPAT

'make savedefconfig' doesn't generate defconfig properly due to missing COMPAT default. So Add default and set to yes.

Signed-off-by Chanho Min <[email protected]>
---
 arch/arm64/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +1 -0
index 4907b85..93b7531 100644
@@ -294,6 +294,7 @@ source "fs/Kconfig.binfmt"
 
 config COMPAT
 	bool "Kernel support for 32-bit EL0"
+	default y
 	depends on !ARM64_64K_PAGES
 	select COMPAT_BINFMT_ELF
 	select HAVE_UID16
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 2 lines · Chanho Min

'make savedefconfig' doesn't generate defconfig properly due to missing COMPAT default. So Add default and set to yes.

I thought a missing `default' line in a Kconfig entry meant that the option ended up defaulting to 'n'. What exactly is the problem you are seeing?

Will

Quoted 21 lines
Signed-off-by Chanho Min <[email protected]>
---
 arch/arm64/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +1 -0
index 4907b85..93b7531 100644
@@ -294,6 +294,7 @@ source "fs/Kconfig.binfmt"
 
 config COMPAT
 	bool "Kernel support for 32-bit EL0"
+	default y
 	depends on !ARM64_64K_PAGES
 	select COMPAT_BINFMT_ELF
 	select HAVE_UID16
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 1/1 arm64:kconfig: make default for CONFIG_COMPAT

Quoted 7 lines

-----Original Message-----
From: Will Deacon [mailto:will.deacon at arm.com]
Sent: Tuesday, April 15, 2014 1:46 AM
To: Chanho Min
Cc: Catalin Marinas; linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] arm64:kconfig: make default for CONFIG_COMPAT

Quoted 6 lines
Quoted 2 lines · Chanho Min

'make savedefconfig' doesn't generate defconfig properly due to missing COMPAT default. So Add default and set to yes.

I thought a missing `default' line in a Kconfig entry meant that the option ended up defaulting to 'n'. What exactly is the problem you are seeing?

Correct minimal config is not generated without default line. If we want to set COMPAT to 'n', 'default n' should be added.

Chanho

Quoted 24 lines

Will

Quoted 21 lines
Signed-off-by Chanho Min <[email protected]>
---
 arch/arm64/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +1 -1
index 4907b85..93b7531 100644
@@ -294,6 +294,7 @@ source "fs/Kconfig.binfmt"
 
 config COMPAT
 	bool "Kernel support for 32-bit EL0"
+	default y
 	depends on !ARM64_64K_PAGES
 	select COMPAT_BINFMT_ELF
 	select HAVE_UID16
--

1.7.9.5

#3 lore raw
In reply to Will Deacon
Quoted 8 lines · On Tuesday 15 April 2014 09:07:00 Chanho Min wrote:
Quoted 8 lines

-----Original Message-----
From: Will Deacon [mailto:will.deacon at arm.com]
Sent: Tuesday, April 15, 2014 1:46 AM
To: Chanho Min
Cc: Catalin Marinas; linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] arm64:kconfig: make default for CONFIG_COMPAT

On Mon, Apr 14, 2014 at 09:08:03AM +0100, Chanho Min wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

'make savedefconfig' doesn't generate defconfig properly due to missing COMPAT default. So Add default and set to yes.

I thought a missing `default' line in a Kconfig entry meant that the option ended up defaulting to 'n'. What exactly is the problem you are seeing?

Correct minimal config is not generated without default line. If we want to set COMPAT to 'n', 'default n' should be added.

That would be pointless, because 'n' is already the default. What do you want to achieve?

Arnd

author
#4 lore raw

PATCH 1/1 arm64:kconfig: make default for CONFIG_COMPAT

Quoted 12 lines · On Tuesday 15 April 2014 09:07:00 Chanho Min wrote:
Quoted 11 lines
Quoted 11 lines

-----Original Message-----
From: Will Deacon [mailto:will.deacon at arm.com]
Sent: Tuesday, April 15, 2014 1:46 AM
To: Chanho Min
Cc: Catalin Marinas; linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] arm64:kconfig: make default for CONFIG_COMPAT

Quoted 2 lines · Chanho Min

'make savedefconfig' doesn't generate defconfig properly due to missing COMPAT default. So Add default and set to yes.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I thought a missing `default' line in a Kconfig entry meant that the option ended up defaulting to 'n'. What exactly is the problem you are seeing?

Correct minimal config is not generated without default line. If we want to set COMPAT to 'n', 'default n' should be added.

That would be pointless, because 'n' is already the default. What do you want to achieve?

Sorry, It is my mistake. Please ignore this patch.

Chanho

Quoted 2 lines

Arnd