Skip to contentSkip to conversation

fswebcam: disable static build

PATCH New Baruch Siach 2 participants 3 messages Apr 13, 2014 – Apr 14, 2014

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/2 fswebcam: disable static build

fswebcam doesn't play nicely with static build as it doesn't track its indirect dependencies in link time. Fixing this requires tracking all indirect optional dependencies, which is tedious and error prone. Just disable static build.

This build failure didn't show on the autobuilder for some reason.

Signed-off-by Baruch Siach <[email protected]>
---
 package/fswebcam/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/fswebcam/Config.in +5 -0
index a894d3b8ace4..03ab38f9f1bb 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_FSWEBCAM
 	bool "fswebcam"
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB
 	select BR2_PACKAGE_GD
 	select BR2_PACKAGE_FREETYPE
 	select BR2_PACKAGE_JPEG

@@ -15,3 +16,7 @@ config BR2_PACKAGE_FSWEBCAM
 	  scp.
 
 	  http://www.firestorm.cx/fswebcam/
+
+comment "fswebcam needs a toolchain w/ dynamic library"
+	depends on BR2_USE_MMU
+	depends on BR2_PREFER_STATIC_LIB
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 fswebcam: bump version to 20140113

Signed-off-by Baruch Siach <[email protected]>
---
 package/fswebcam/fswebcam.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/fswebcam/fswebcam.mk +1 -1
index 2275fb56a639..357341ce2e7e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-FSWEBCAM_VERSION = 20110717
+FSWEBCAM_VERSION = 20140113
 FSWEBCAM_SITE = http://www.firestorm.cx/fswebcam/files/
 FSWEBCAM_LICENSE = GPLv2
 FSWEBCAM_LICENSE_FILES = LICENSE
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/2 fswebcam: disable static build

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 11 lines · Baruch Siach

fswebcam doesn't play nicely with static build as it doesn't track its indirect dependencies in link time. Fixing this requires tracking all indirect optional dependencies, which is tedious and error prone. Just disable static build.

This build failure didn't show on the autobuilder for some reason.

Signed-off-by Baruch Siach <[email protected]>
---
 package/fswebcam/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Both applied. I would have preferred to fix static linking, but I agree it's pretty unlikely that anyone will ever use such an application statically linked and so it's probably not worth the effort.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com