Skip to contentSkip to conversation

PCI: Add Patsburg (X79) to Intel PCH root port ACS quirk

PATCH In review Alex Williamson 3 participants 3 messages Mar 31, 2014 – Apr 15, 2014 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: Add Patsburg (X79) to Intel PCH root port ACS quirk

Intel has updated Red Hat bz1037684 to note that X79 PCH root ports also provide isolation and the same ACS quirks apply. Some sources indicate additional device IDs for X79, but this patch includes only the ones specifically identified by Intel:
https://bugzilla.redhat.com/show_bug.cgi?id=1037684#c11

---
 drivers/pci/quirks.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/pci/quirks.c +2 -0
index e729206..5e4ac63 100644
@@ -3453,6 +3453,8 @@ static const u16 pci_quirk_intel_pch_acs_ids[] = {
 	/* Wildcat PCH */
 	0x9c90, 0x9c91, 0x9c92, 0x9c93, 0x9c94, 0x9c95, 0x9c96, 0x9c97,
 	0x9c98, 0x9c99, 0x9c9a, 0x9c9b,
+	/* Patsburg (X79) PCH */
+	0x1d10, 0x1d12, 0x1d14, 0x1d16, 0x1d18, 0x1d1a, 0x1d1c, 0x1d1e,
 };
 
 static bool pci_quirk_intel_pch_acs_match(struct pci_dev *dev)
Acked-by on v1 1/1
#1 lore raw

QWNrZWQtYnk6IERvbiBEdWdnZXIgPGRvbmFsZC5kLmR1Z2dlckBpbnRlbC5jb20+DQoNCg0KLS0t LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEFsZXggV2lsbGlhbXNvbiBbbWFpbHRvOmFs ZXgud2lsbGlhbXNvbkByZWRoYXQuY29tXSANClNlbnQ6IE1vbmRheSwgTWFyY2ggMzEsIDIwMTQg MTI6MjIgUE0NClRvOiBiaGVsZ2Fhc0Bnb29nbGUuY29tDQpDYzogbGludXgtcGNpQHZnZXIua2Vy bmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgRHVnZ2VyLCBEb25hbGQgRA0K U3ViamVjdDogW1BBVENIXSBQQ0k6IEFkZCBQYXRzYnVyZyAoWDc5KSB0byBJbnRlbCBQQ0ggcm9v dCBwb3J0IEFDUyBxdWlyaw0KDQpJbnRlbCBoYXMgdXBkYXRlZCBSZWQgSGF0IGJ6MTAzNzY4NCB0 byBub3RlIHRoYXQgWDc5IFBDSCByb290IHBvcnRzIGFsc28gcHJvdmlkZSBpc29sYXRpb24gYW5k IHRoZSBzYW1lIEFDUyBxdWlya3MgYXBwbHkuICBTb21lIHNvdXJjZXMgaW5kaWNhdGUgYWRkaXRp b25hbCBkZXZpY2UgSURzIGZvciBYNzksIGJ1dCB0aGlzIHBhdGNoIGluY2x1ZGVzIG9ubHkgdGhl IG9uZXMgc3BlY2lmaWNhbGx5IGlkZW50aWZpZWQgYnkgSW50ZWw6DQpodHRwczovL2J1Z3ppbGxh LnJlZGhhdC5jb20vc2hvd19idWcuY2dpP2lkPTEwMzc2ODQjYzExDQoNClNpZ25lZC1vZmYtYnk6 IEFsZXggV2lsbGlhbXNvbiA8YWxleC53aWxsaWFtc29uQHJlZGhhdC5jb20+DQpDYzogRG9uIER1 Z2dlciA8ZG9uYWxkLmQuZHVnZ2VyQGludGVsLmNvbT4NCi0tLQ0KIGRyaXZlcnMvcGNpL3F1aXJr cy5jIHwgICAgMiArKw0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykNCg0KZGlmZiAt LWdpdCBhL2RyaXZlcnMvcGNpL3F1aXJrcy5jIGIvZHJpdmVycy9wY2kvcXVpcmtzLmMgaW5kZXgg ZTcyOTIwNi4uNWU0YWM2MyAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvcGNpL3F1aXJrcy5jDQorKysg Yi9kcml2ZXJzL3BjaS9xdWlya3MuYw0KQEAgLTM0NTMsNiArMzQ1Myw4IEBAIHN0YXRpYyBjb25z dCB1MTYgcGNpX3F1aXJrX2ludGVsX3BjaF9hY3NfaWRzW10gPSB7DQogCS8qIFdpbGRjYXQgUENI ICovDQogCTB4OWM5MCwgMHg5YzkxLCAweDljOTIsIDB4OWM5MywgMHg5Yzk0LCAweDljOTUsIDB4 OWM5NiwgMHg5Yzk3LA0KIAkweDljOTgsIDB4OWM5OSwgMHg5YzlhLCAweDljOWIsDQorCS8qIFBh dHNidXJnIChYNzkpIFBDSCAqLw0KKwkweDFkMTAsIDB4MWQxMiwgMHgxZDE0LCAweDFkMTYsIDB4 MWQxOCwgMHgxZDFhLCAweDFkMWMsIDB4MWQxZSwNCiB9Ow0KIA0KIHN0YXRpYyBib29sIHBjaV9x dWlya19pbnRlbF9wY2hfYWNzX21hdGNoKHN0cnVjdCBwY2lfZGV2ICpkZXYpDQoNCg==

maintainer
#2 lore raw
In reply to Alex Williamson
Quoted 8 lines · Alex Williamson

Intel has updated Red Hat bz1037684 to note that X79 PCH root ports also provide isolation and the same ACS quirks apply. Some sources indicate additional device IDs for X79, but this patch includes only the ones specifically identified by Intel:
https://bugzilla.redhat.com/show_bug.cgi?id=1037684#c11

Applied with Don's ack to pci/virtualization for v3.16, thanks!

Quoted 18 lines
---
 drivers/pci/quirks.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/pci/quirks.c +2 -0
index e729206..5e4ac63 100644
@@ -3453,6 +3453,8 @@ static const u16 pci_quirk_intel_pch_acs_ids[] = {
 	/* Wildcat PCH */
 	0x9c90, 0x9c91, 0x9c92, 0x9c93, 0x9c94, 0x9c95, 0x9c96, 0x9c97,
 	0x9c98, 0x9c99, 0x9c9a, 0x9c9b,
+	/* Patsburg (X79) PCH */
+	0x1d10, 0x1d12, 0x1d14, 0x1d16, 0x1d18, 0x1d1a, 0x1d1c, 0x1d1e,
 };
 
 static bool pci_quirk_intel_pch_acs_match(struct pci_dev *dev)