pata_samsung_cf: fix ata_host_activate() failure handling

Add missing clk_disable() call to ata_host_activate() failure path.

Cc Ben Dooks <[email protected]>

Cc Kukjin Kim <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 drivers/ata/pata_samsung_cf.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Index: b/drivers/ata/pata_samsung_cf.c
===================================================================

drivers/ata/pata_samsung_cf.c +7 -4

@@ -594,9 +594,13 @@ static int __init pata_s3c_probe(struct
 
 	platform_set_drvdata(pdev, host);
 
-	return ata_host_activate(host, info->irq,
-			info->irq ? pata_s3c_irq : NULL,
-			0, &pata_s3c_sht);
+	ret = ata_host_activate(host, info->irq,
+				info->irq ? pata_s3c_irq : NULL,
+				0, &pata_s3c_sht);
+	if (ret)
+		goto stop_clk;
+
+	return 0;
 
 stop_clk:
 	clk_disable(info->clk);
 
--

Quoted 6 lines · Tejun Heo

Add missing clk_disable() call to ata_host_activate() failure path.

Cc Ben Dooks <[email protected]>

Cc Kukjin Kim <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

Reviewed-by Jingoo Han <[email protected]>

Best regards,
Jingoo Han

Quoted 27 lines

---
 drivers/ata/pata_samsung_cf.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Index: b/drivers/ata/pata_samsung_cf.c
===================================================================

drivers/ata/pata_samsung_cf.c +7 -4

@@ -594,9 +594,13 @@ static int __init pata_s3c_probe(struct
 
 	platform_set_drvdata(pdev, host);
 
-	return ata_host_activate(host, info->irq,
-			info->irq ? pata_s3c_irq : NULL,
-			0, &pata_s3c_sht);
+	ret = ata_host_activate(host, info->irq,
+				info->irq ? pata_s3c_irq : NULL,
+				0, &pata_s3c_sht);
+	if (ret)
+		goto stop_clk;
+
+	return 0;
 
 stop_clk:
 	clk_disable(info->clk);
 
--

Add missing clk_disable() call to ata_host_activate() failure path.

Cc Ben Dooks <[email protected]>

Cc Kukjin Kim <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>