Skip to contentSkip to conversation

regulator: tps65217: Remove *rdev[] from struct tps65217

PATCH Applied Axel Lin 3 participants 3 messages Apr 15, 2014 – Apr 18, 2014

Subsystems (3)
Multifunction devices (MFD) OMAP2+ support Voltage and current regulator framework
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: tps65217: Remove *rdev[] from struct tps65217

Now this driver uses devm_regulator_register() so we don't need to save rdev pointer to tps->rdev[i] for cleanup.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/tps65217-regulator.c | 3 ---
 include/linux/mfd/tps65217.h           | 1 -
 2 files changed, 4 deletions(-)
drivers/regulator/tps65217-regulator.c +0 -3
index 10b78d2..8482f6b 100644
@@ -257,9 +257,6 @@ static int tps65217_regulator_probe(struct platform_device *pdev)
 				pdev->name);
 			return PTR_ERR(rdev);
 		}
-
-		/* Save regulator for cleanup */
-		tps->rdev[i] = rdev;
 	}
 	return 0;
 }
include/linux/mfd/tps65217.h +0 -1
index 54b5458..95d6938 100644
@@ -254,7 +254,6 @@ struct tps65217 {
 	struct tps65217_board *pdata;
 	unsigned long id;
 	struct regulator_desc desc[TPS65217_NUM_REGULATOR];
-	struct regulator_dev *rdev[TPS65217_NUM_REGULATOR];
 	struct regmap *regmap;
 };
Signature · 1 line
1.8.3.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines

Now this driver uses devm_regulator_register() so we don't need to save rdev pointer to tps->rdev[i] for cleanup.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/tps65217-regulator.c | 3 ---
 include/linux/mfd/tps65217.h           | 1 -
 2 files changed, 4 deletions(-)

For the MFD part:

Acked-by Lee Jones <[email protected]>
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
maintainer Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

Now this driver uses devm_regulator_register() so we don't need to save rdev pointer to tps->rdev[i] for cleanup.

Applied, thanks.