Skip to contentSkip to conversation

staging: panel: fix sparse warnings.

PATCH In review Bastien Armand 2 participants 2 messages Apr 18, 2014 – Apr 20, 2014

lore
Share & tools
lore
#0 lore raw

v2 cover staging: panel: fix sparse warnings.

This serie of two patch fix the following sparse warnings in panel.c :
panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces)
panel.c:1235:26: expected void const volatile [noderef] <asn:1>*<noident>
panel.c:1235:26: got char const *tmp
panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
panel.c:1353:20: expected int ( *write )( ... )
panel.c:1353:20: got int ( static [toplevel] *<noident> )( ... )
panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces)
panel.c:1591:17: expected void const volatile [noderef] <asn:1>*<noident>
panel.c:1591:17: got char *tmp
panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
panel.c:1620:20: expected int ( *read )( ... )
panel.c:1620:20: got int ( static [toplevel] *<noident> )( ... )

Changes since v1 :
- splitted patch in two

Bastien Armand (2):
staging: panel: fix sparse warnings in keypad_read
staging: panel: fix sparse warnings in lcd_write

 drivers/staging/panel/panel.c |  209 ++++++++++++++++++++++-------------------
 1 file changed, 111 insertions(+), 98 deletions(-)

--
1.7.10.4

Acked-by on the v2 series
#1 lore raw

Hi Bastien,

Quoted 14 lines · Bastien Armand

This serie of two patch fix the following sparse warnings in panel.c :
panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces)
panel.c:1235:26: expected void const volatile [noderef] <asn:1>*<noident>
panel.c:1235:26: got char const *tmp
panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
panel.c:1353:20: expected int ( *write )( ... )
panel.c:1353:20: got int ( static [toplevel] *<noident> )( ... )
panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces)
panel.c:1591:17: expected void const volatile [noderef] <asn:1>*<noident>
panel.c:1591:17: got char *tmp
panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
panel.c:1620:20: expected int ( *read )( ... )
panel.c:1620:20: got int ( static [toplevel] *<noident> )( ... )

Quoted 6 lines

Changes since v1 :
- splitted patch in two

Bastien Armand (2):
staging: panel: fix sparse warnings in keypad_read
staging: panel: fix sparse warnings in lcd_write

Just reviewed them both and I'm fine with these patches. You can add my :

Willy