buildman: make output dir configurable

PATCH New Daniel Schwierzeck 3 participants 7 messages Mar 28, 2014 – Apr 18, 2014

Share & tools

Daniel Schwierzeck

author

2014-03-28 20:46 UTC #0 lore raw

PATCH 1/1 buildman: make output dir configurable

Add an option to specify the output directory to override the default path '../'. This is useful for building in a ramdisk.

Signed-off-by Daniel Schwierzeck <[email protected]>

Cc Simon Glass <[email protected]>

---
 tools/buildman/buildman.py | 2 ++
 tools/buildman/control.py  | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

tools/buildman/buildman.py +2 -0

index 8822efe..0d95246 100755
@@ -101,6 +101,8 @@ parser.add_option('-T', '--threads', type='int',
        default=None, help='Number of builder threads to use')
 parser.add_option('-u', '--show_unknown', action='store_true',
        default=False, help='Show boards with unknown build result')
+parser.add_option('-o', '--output-dir', type='string',
+       dest='output_dir', default='..', help='Output directory')
 
 parser.usage = """buildman -b <branch> [options]

tools/buildman/control.py +1 -1

index 8e6a08f..d2f4102 100644
@@ -145,7 +145,7 @@ def DoBuildman(options, args):
         options.step = len(series.commits) - 1
 
     # Create a new builder with the selected options
-    output_dir = os.path.join('..', options.branch)
+    output_dir = os.path.join(options.output_dir, options.branch)
     builder = Builder(toolchains, output_dir, options.git_dir,
             options.threads, options.jobs, checkout=True,
             show_unknown=options.show_unknown, step=options.step)

Signature · 1 line

1.8.3.2

Simon Glass

2014-04-08 19:35 UTC #1 lore raw

PATCH 1/1 buildman: make output dir configurable

Hi Daniel,

Quoted 15 lines · Daniel Schwierzeck

Add an option to specify the output directory to override the default path '../'. This is useful for building in a ramdisk.
Signed-off-by Daniel Schwierzeck <[email protected]>
Cc Simon Glass <[email protected]>
---
 tools/buildman/buildman.py | 2 ++
 tools/buildman/control.py  | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
tools/buildman/buildman.py +0 -0
index 8822efe..0d95246 100755

tools/buildman/buildman.py parser.add_option('-T', '--threads', type='int', · line 106

Quoted 6 lines

tools/buildman/buildman.py +2 -0

@@ -101,6 +101,8 @@ parser.add_option('-T', '--threads', type='int',
        default=None, help='Number of builder threads to use')
 parser.add_option('-u', '--show_unknown', action='store_true',
        default=False, help='Show boards with unknown build result')
+parser.add_option('-o', '--output-dir', type='string',
+       dest='output_dir', default='..', help='Output directory')

Can you expand the help here a bit? This is the directory where all the builds happen, with a separate sub-directory for each commit. It also holds the working directory (.bm-work). So maybe 'Build output directory, also used for working space' ?

Quoted 17 lines

tools/buildman/buildman.py +0 -0

 parser.usage = """buildman -b <branch> [options]

tools/buildman/control.py +1 -2

index 8e6a08f..d2f4102 100644
@@ -145,7 +145,7 @@ def DoBuildman(options, args):
         options.step = len(series.commits) - 1
 
     # Create a new builder with the selected options
-    output_dir = os.path.join('..', options.branch)
+    output_dir = os.path.join(options.output_dir, options.branch)
     builder = Builder(toolchains, output_dir, options.git_dir,
             options.threads, options.jobs, checkout=True,
             show_unknown=options.show_unknown, step=options.step)
--

Quoted 3 lines

1.8.3.2

Regards,
Simon

Daniel Schwierzeck

author

2014-04-08 19:52 UTC #2 lore raw

PATCH 1/1 buildman: make output dir configurable

2014-04-08 21:35 GMT+02:00 Simon Glass <[email protected]>:

Quoted 15 lines

Hi Daniel,
Quoted 11 lines · Daniel Schwierzeck
Add an option to specify the output directory to override the default path '../'. This is useful for building in a ramdisk.
Signed-off-by Daniel Schwierzeck <[email protected]>
Cc Simon Glass <[email protected]>
---
 tools/buildman/buildman.py | 2 ++
 tools/buildman/control.py  | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

Quoted 17 lines

tools/buildman/buildman.py parser.add_option('-T', '--threads', type='int', · line 105
Quoted 10 lines
tools/buildman/buildman.py +2 -0
index 8822efe..0d95246 100755
@@ -101,6 +101,8 @@ parser.add_option('-T', '--threads', type='int',
        default=None, help='Number of builder threads to use')
 parser.add_option('-u', '--show_unknown', action='store_true',
        default=False, help='Show boards with unknown build result')
+parser.add_option('-o', '--output-dir', type='string',
+       dest='output_dir', default='..', help='Output directory')
Can you expand the help here a bit? This is the directory where all the builds happen, with a separate sub-directory for each commit. It also holds the working directory (.bm-work). So maybe 'Build output directory, also used for working space' ?

sure. How about that?

-o OUTPUT_DIR, --output-dir=OUTPUT_DIR
Directory where all builds happen and buildman has its workspace (default is ../)

Signature · 1 line

- Daniel

Simon Glass

2014-04-10 03:00 UTC #3 lore raw

PATCH 1/1 buildman: make output dir configurable

Hi Daniel,

Quoted 36 lines · Daniel Schwierzeck

2014-04-08 21:35 GMT+02:00 Simon Glass <[email protected]>:
Quoted 16 lines
Hi Daniel,
On 28 March 2014 14:46, Daniel Schwierzeck <[email protected]
Quoted 11 lines · wrote:
Add an option to specify the output directory to override the default path '../'. This is useful for building in a ramdisk.
Signed-off-by Daniel Schwierzeck <[email protected]>
Cc Simon Glass <[email protected]>
---
 tools/buildman/buildman.py | 2 ++
 tools/buildman/control.py  | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
Quoted 14 lines
tools/buildman/buildman.py parser.add_option('-T', '--threads', type='int', · line 105
Quoted 10 lines
tools/buildman/buildman.py +2 -0
index 8822efe..0d95246 100755
@@ -101,6 +101,8 @@ parser.add_option('-T', '--threads', type='int',
        default=None, help='Number of builder threads to use')
 parser.add_option('-u', '--show_unknown', action='store_true',
        default=False, help='Show boards with unknown build result')
+parser.add_option('-o', '--output-dir', type='string',
+       dest='output_dir', default='..', help='Output directory')
Can you expand the help here a bit? This is the directory where all the builds happen, with a separate sub-directory for each commit. It also
holds
Quoted 3 lines
the working directory (.bm-work). So maybe 'Build output directory, also used for working space' ?

Quoted 7 lines

sure. How about that?
-o OUTPUT_DIR, --output-dir=OUTPUT_DIR
Directory where all builds happen and buildman has
its
workspace (default is ../)

SGTM

- Simon

Daniel Schwierzeck

author

2014-04-17 19:13 UTC #4 lore raw

PATCH v2 1/1 buildman: make output dir configurable

In reply to Daniel Schwierzeck

Add an option to specify the output directory to override the default path '../'. This is useful for building in a ramdisk.

Signed-off-by Daniel Schwierzeck <[email protected]>

Cc Simon Glass <[email protected]>

---
Changes for v2:
- improved help message

---
 tools/buildman/buildman.py | 3 +++
 tools/buildman/control.py  | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

tools/buildman/buildman.py +3 -0

index 8822efe..73a5483 100755
@@ -101,6 +101,9 @@ parser.add_option('-T', '--threads', type='int',
        default=None, help='Number of builder threads to use')
 parser.add_option('-u', '--show_unknown', action='store_true',
        default=False, help='Show boards with unknown build result')
+parser.add_option('-o', '--output-dir', type='string',
+       dest='output_dir', default='..',
+       help='Directory where all builds happen and buildman has its workspace (default is ../)')
 
 parser.usage = """buildman -b <branch> [options]

tools/buildman/control.py +1 -1

index 8e6a08f..d2f4102 100644
@@ -145,7 +145,7 @@ def DoBuildman(options, args):
         options.step = len(series.commits) - 1
 
     # Create a new builder with the selected options
-    output_dir = os.path.join('..', options.branch)
+    output_dir = os.path.join(options.output_dir, options.branch)
     builder = Builder(toolchains, output_dir, options.git_dir,
             options.threads, options.jobs, checkout=True,
             show_unknown=options.show_unknown, step=options.step)

Signature · 1 line

1.8.3.2

Simon Glass

2014-04-17 19:33 UTC #5 lore raw

PATCH v2 1/1 buildman: make output dir configurable

Quoted 5 lines · Daniel Schwierzeck

Add an option to specify the output directory to override the default path '../'. This is useful for building in a ramdisk.
Signed-off-by Daniel Schwierzeck <[email protected]>
Cc Simon Glass <[email protected]>

Thanks.

Acked-by Simon Glass <[email protected]>

Tom Rini

2014-04-18 21:03 UTC #6 lore raw

PATCH v2 1/1 buildman: make output dir configurable

In reply to Daniel Schwierzeck

Quoted 6 lines · Daniel Schwierzeck

Add an option to specify the output directory to override the default path '../'. This is useful for building in a ramdisk.
Signed-off-by Daniel Schwierzeck <[email protected]>
Cc Simon Glass <[email protected]>
Acked-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140418/4a85dc75/attachment.pgp>