Skip to contentSkip to conversation

apr: add missing comment about needed dynamic library support

PATCH New Davide Viti 2 participants 2 messages Apr 18, 2014 – Apr 19, 2014

lore
Share & tools
lore

Davide Viti

author
#0 lore raw

PATCH 1/1 apr: add missing comment about needed dynamic library support

From: Davide Viti <[email protected]>

Signed-off-by Davide Viti <[email protected]>
---
 package/apr/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/apr/Config.in +4 -0
index e06d254..73a4482 100644
@@ -9,3 +9,7 @@ config BR2_PACKAGE_APR
 	  consistent interface to underlying platform-specific implementations
 
 	  http://apr.apache.org/
+
+comment "apr needs a toolchain w/ dynamic library"
+	depends on !BR2_USE_MMU
+	depends on BR2_PREFER_STATIC_LIB
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 apr: add missing comment about needed dynamic library support

Dear Davide Viti,

Quoted 6 lines · Davide Viti

From: Davide Viti <[email protected]>

Signed-off-by Davide Viti <[email protected]>
---
 package/apr/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Applied, thanks, but I had to fix something:

package/apr/Config.in config BR2_PACKAGE_APR · line 14

Quoted 11 lines
package/apr/Config.in +3 -0
index e06d254..73a4482 100644
@@ -9,3 +9,7 @@ config BR2_PACKAGE_APR
 	  consistent interface to underlying platform-specific implementations
 
 	  http://apr.apache.org/
+
+comment "apr needs a toolchain w/ dynamic library"
+	depends on !BR2_USE_MMU

This should have been "depends on BR2_USE_MMU". The apr package is only available on architectures having an MMU. So there's no point in displaying the comment if we're on an MMU-less platform.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com