Skip to contentSkip to conversation

graphs: store and keep intermediate 'dot' program for graph-depends

PATCH New Yann E. MORIN 3 participants 3 messages Apr 19, 2014 Kbuild

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 graphs: store and keep intermediate 'dot' program for graph-depends

From: "Yann E. MORIN" <[email protected]>

Currently, graph-depends (and PKG-graph-depends) do not store the intermediate 'dot' program.

Some users would like to get the dot program to be able to further customise the generated graphs (eg. modify the layout, colorise some of the packages...)

So, store the intermediate dot program alongside the generated graph.

Reported-by Maxime Hadjinlian <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 Makefile               | 1 +
 package/pkg-generic.mk | 1 +
 2 files changed, 2 insertions(+)
Makefile +1 -0
index 42adf7c..dd47f77 100644
@@ -670,6 +670,7 @@ graph-depends:
 	@$(INSTALL) -d $(O)/graphs
 	@cd "$(CONFIG_DIR)"; \
 	$(TOPDIR)/support/scripts/graph-depends -d $(BR_GRAPH_DEPTH) \
+	|tee $(O)/graphs/$(@).dot \
 	|dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$(@).$(BR_GRAPH_OUT)
 
 else # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
package/pkg-generic.mk +1 -0
index 8a62d4c..cf02210 100644
@@ -496,6 +496,7 @@ $(1)-graph-depends:
 			@$(INSTALL) -d $(O)/graphs
 			@cd "$(CONFIG_DIR)"; \
 			$(TOPDIR)/support/scripts/graph-depends -p $(1) -d $(BR_GRAPH_DEPTH) \
+			|tee $(O)/graphs/$$(@).dot \
 			|dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$$(@).$(BR_GRAPH_OUT)
 
 $(1)-dirclean:		$$($(2)_TARGET_DIRCLEAN)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 graphs: store and keep intermediate 'dot' program for graph-depends

Acked-by "Maxime Hadjinlian" <[email protected]>
Quoted 45 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

Currently, graph-depends (and PKG-graph-depends) do not store the intermediate 'dot' program.

Some users would like to get the dot program to be able to further customise the generated graphs (eg. modify the layout, colorise some of the packages...)

So, store the intermediate dot program alongside the generated graph.

Reported-by Maxime Hadjinlian <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 Makefile               | 1 +
 package/pkg-generic.mk | 1 +
 2 files changed, 2 insertions(+)
Makefile +1 -0
index 42adf7c..dd47f77 100644
@@ -670,6 +670,7 @@ graph-depends:
        @$(INSTALL) -d $(O)/graphs
        @cd "$(CONFIG_DIR)"; \
        $(TOPDIR)/support/scripts/graph-depends -d $(BR_GRAPH_DEPTH) \
+       |tee $(O)/graphs/$(@).dot \
        |dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$(@).$(BR_GRAPH_OUT)
 
 else # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
package/pkg-generic.mk +1 -1
index 8a62d4c..cf02210 100644
@@ -496,6 +496,7 @@ $(1)-graph-depends:
                        @$(INSTALL) -d $(O)/graphs
                        @cd "$(CONFIG_DIR)"; \
                        $(TOPDIR)/support/scripts/graph-depends -p $(1) -d $(BR_GRAPH_DEPTH) \
+                       |tee $(O)/graphs/$$(@).dot \
                        |dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$$(@).$(BR_GRAPH_OUT)
 
 $(1)-dirclean:         $$($(2)_TARGET_DIRCLEAN)
--

1.8.3.2

Applied
#2 lore raw

PATCH 1/1 graphs: store and keep intermediate 'dot' program for graph-depends

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 5 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

Currently, graph-depends (and PKG-graph-depends) do not store the intermediate 'dot' program.

Quoted 8 lines

Some users would like to get the dot program to be able to further customise the generated graphs (eg. modify the layout, colorise some of the packages...)

So, store the intermediate dot program alongside the generated graph.

Reported-by Maxime Hadjinlian <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com