eject: fix multilib builds and wrong return value of usage

PATCH Applied [email protected] 3 participants 9 messages Apr 9, 2014 – Apr 22, 2014

lore

Share & tools

lore

[email protected]

author

2014-04-09 06:26 UTC #0 lore raw

cover eject: fix multilib builds and wrong return value of usage

From: Jackie Huang <[email protected]>

---
The following changes since commit bc969d3705c45928de8525ef3d2d9d2867311864:

inetutils: add -dbg packages for tftpd, telnetd and rshd (2014-04-02 11:18:54 -0400)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib jhuang0/r_eject_1
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/r_eject_1

Jackie Huang (2):
eject: fix multilib builds
eject: Fix wrong return value

 .../eject/eject/eject-2.1.5-error-return.patch     |   10 ++++++++++
 meta-oe/recipes-support/eject/eject_2.1.5.bb       |    6 ++++--
 2 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch

Signature · 1 line

1.7.9.5

[email protected]

author

2014-04-09 06:26 UTC #1 lore raw

PATCH 1/2 eject: fix multilib builds

From: Jackie Huang <[email protected]>

Use BPN instead of PN, BP instead of P to fix the multilib builds.

Signed-off-by Randy MacLeod <[email protected]>

Signed-off-by Jackie Huang <[email protected]>

---
 meta-oe/recipes-support/eject/eject_2.1.5.bb |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

meta-oe/recipes-support/eject/eject_2.1.5.bb +2 -2

index 3f2c90d..98319a3 100644
@@ -5,12 +5,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
 
 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${P}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] = "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"
 
-S = "${WORKDIR}/${PN}"
+S = "${WORKDIR}/${BPN}"
 
 PR = "r1"

Signature · 1 line

1.7.9.5

Martin Jansa

Applied

2014-04-20 11:21 UTC #2 lore raw

Re: [meta-oe][PATCH 1/2] eject: fix multilib builds

Quoted 3 lines · On Wed, Apr 09, 2014 at 02:27:08PM +0800, [email protected] wrote:

From: Jackie Huang <[email protected]>
Use BPN instead of PN, BP instead of P to fix the multilib builds.

Merged, thanks!

Quoted 34 lines

Signed-off-by Randy MacLeod <[email protected]>

Signed-off-by Jackie Huang <[email protected]>

---
 meta-oe/recipes-support/eject/eject_2.1.5.bb |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

meta-oe/recipes-support/eject/eject_2.1.5.bb +2 -2

index 3f2c90d..98319a3 100644
@@ -5,12 +5,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
 
 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${P}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] = "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"
 
-S = "${WORKDIR}/${PN}"
+S = "${WORKDIR}/${BPN}"
 
 PR = "r1"

Signature · 7 lines

1.7.9.5

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

[email protected]

author

2014-04-09 06:26 UTC #3 lore raw

PATCH 2/2 eject: Fix wrong return value

In reply to [email protected]

From: Jackie Huang <[email protected]>

Remove the unnecessary return(1) from function usage(), so that eject -h can return the right value.

Signed-off-by Zhangle Yang <[email protected]>

Signed-off-by Jackie Huang <[email protected]>

---
 .../eject/eject/eject-2.1.5-error-return.patch     |   10 ++++++++++
 meta-oe/recipes-support/eject/eject_2.1.5.bb       |    4 +++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch

meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +10 -0

new file mode 100644
index 0000000..2cce3c3
@@ -0,0 +1,10 @@
+Upstream-Status: Pending
+
+--- eject/eject.c.orig	2013-09-11 18:08:36.000000000 +0800
++++ eject/eject.c	2013-09-11 18:09:05.000000000 +0800
+@@ -207,7 +207,6 @@
+ "If omitted, name defaults to `%s'.\n"
+ "By default tries -r, -s, -f, and -q in order until success.\n"),
+ 			DEFAULTDEVICE);
+-  exit(1);
+ }

meta-oe/recipes-support/eject/eject_2.1.5.bb +3 -1

index 98319a3..c47c653 100644
@@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
 
 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \
+           file://eject-2.1.5-error-return.patch \
+"
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] = "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"

Signature · 1 line

1.7.9.5

Khem Raj

2014-04-09 08:13 UTC #4 lore raw

Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value

Quoted 5 lines · On Apr 8, 2014 8:27 PM, <[email protected]> wrote:

From: Jackie Huang <[email protected]>
Remove the unnecessary return(1) from function usage(), so that eject -h can return the right value.

this is an API change i wonder if other programs rely on the value being >0

Quoted 8 lines

Signed-off-by Zhangle Yang <[email protected]>
Signed-off-by Jackie Huang <[email protected]>
---
 .../eject/eject/eject-2.1.5-error-return.patch     |   10 ++++++++++
 meta-oe/recipes-support/eject/eject_2.1.5.bb       |    4 +++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644

meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch

Quoted 2 lines

diff --git

a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch

Review

Quoted 16 lines

new file mode 100644
index 0000000..2cce3c3

meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +10 -0

@@ -0,0 +1,10 @@
+Upstream-Status: Pending
+
+--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800
++++ eject/eject.c      2013-09-11 18:09:05.000000000 +0800
+@@ -207,7 +207,6 @@
+ "If omitted, name defaults to `%s'.\n"
+ "By default tries -r, -s, -f, and -q in order until success.\n"),
+                       DEFAULTDEVICE);
+-  exit(1);
+ }

(quoted diff) +0 -0

eject_2.1.5.bb

meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM =

Quoted 4 lines

index 98319a3..c47c653 100644
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -0
@@ -5,7 +5,9 @@ LIC_FILES_CHKSUM =

"file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"

meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"

Quoted 10 lines

meta-oe/recipes-support/eject/eject_2.1.5.bb +3 -1

 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \
+           file://eject-2.1.5-error-return.patch \
+"
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] =

"ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"

Quoted 8 lines

meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -1
--
1.7.9.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Huang, Jie (Jackie)

author

2014-04-09 08:35 UTC #5 lore raw

Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value

Quoted 9 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Khem Raj
Sent: Wednesday, April 09, 2014 4:13 PM
To: [email protected]
Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value

Quoted 8 lines

Quoted 5 lines · On Apr 8, 2014 8:27 PM, <[email protected]> wrote:
From: Jackie Huang <[email protected]>
Remove the unnecessary return(1) from function usage(), so that eject -h can return the right value.
this is an API change i wonder if other programs rely on the value being >0

I think the answer should be no, I don't see any reason to return 1 for the "-h" or "--help", almost all programs return 0 for that, right?

Thanks,
Jackie

Quoted 58 lines

Quoted 7 lines
Signed-off-by Zhangle Yang <[email protected]>
Signed-off-by Jackie Huang <[email protected]>
---
 .../eject/eject/eject-2.1.5-error-return.patch     |   10 ++++++++++
 meta-oe/recipes-support/eject/eject_2.1.5.bb       |    4 +++-
 2 files changed, 13 insertions(+), 1 deletion(-)  create mode 100644
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 2 lines
diff --git
a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Review
Quoted 16 lines
new file mode 100644
index 0000000..2cce3c3
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +10 -0
@@ -0,0 +1,10 @@
+Upstream-Status: Pending
+
+--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800
++++ eject/eject.c      2013-09-11 18:09:05.000000000 +0800
+@@ -207,7 +207,6 @@
+ "If omitted, name defaults to `%s'.\n"
+ "By default tries -r, -s, -f, and -q in order until success.\n"),
+                       DEFAULTDEVICE);
+-  exit(1);
+ }
(quoted diff) +0 -0
eject_2.1.5.bb
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM =
Quoted 4 lines
index 98319a3..c47c653 100644
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -0
@@ -5,7 +5,9 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
Quoted 10 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +3 -1
 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \
+           file://eject-2.1.5-error-return.patch \
+"
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] =
"ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"
Quoted 8 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -1
--
1.7.9.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Khem Raj

2014-04-09 15:49 UTC #6 lore raw

Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value

Quoted 5 lines · Jie (Jackie)

Quoted 5 lines
-----Original Message-----
From: [email protected] [mailto:

openembedded-devel-

Quoted 5 lines

Quoted 5 lines
[email protected]] On Behalf Of Khem Raj
Sent: Wednesday, April 09, 2014 4:13 PM
To: [email protected]
Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value

Quoted 8 lines

Quoted 8 lines · On Apr 8, 2014 8:27 PM, <[email protected]> wrote:
Quoted 5 lines
From: Jackie Huang <[email protected]>
Remove the unnecessary return(1) from function usage(), so that eject -h can return the right value.
this is an API change i wonder if other programs rely on the value

being >0

Quoted 2 lines

I think the answer should be no, I don't see any reason to return 1 for

the "-h" or

Quoted 2 lines

"--help", almost all programs return 0 for that, right?

mostly yes and change is ok too just discuss it with package community and see if this is ok.

Quoted 19 lines

Thanks,
Jackie
Quoted 16 lines
Quoted 7 lines
Signed-off-by Zhangle Yang <[email protected]>
Signed-off-by Jackie Huang <[email protected]>
---
 .../eject/eject/eject-2.1.5-error-return.patch     |   10 ++++++++++
 meta-oe/recipes-support/eject/eject_2.1.5.bb       |    4 +++-
 2 files changed, 13 insertions(+), 1 deletion(-)  create mode 100644
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 2 lines
diff --git
a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 4 lines
new file mode 100644
index 0000000..2cce3c3
--- /dev/null
+++

b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch

Quoted 4 lines

Quoted 4 lines
Quoted 4 lines
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +3 -0
@@ -0,0 +1,10 @@
+Upstream-Status: Pending
+
+--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +7 -0
++++ eject/eject.c      2013-09-11 18:09:05.000000000 +0800
+@@ -207,7 +207,6 @@
+ "If omitted, name defaults to `%s'.\n"
+ "By default tries -r, -s, -f, and -q in order until success.\n"),
+                       DEFAULTDEVICE);
+-  exit(1);
+ }
diff --git

a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-support/eject/

Quoted 35 lines

Quoted 25 lines
eject_2.1.5.bb
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM =
Quoted 4 lines
index 98319a3..c47c653 100644
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -0
@@ -5,7 +5,9 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
Quoted 10 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +3 -1
 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \
+           file://eject-2.1.5-error-return.patch \
+"
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] =
"ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"
Quoted 8 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -1
--
1.7.9.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Huang, Jie (Jackie)

author

2014-04-10 01:14 UTC #7 lore raw

Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value

Quoted 32 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Khem Raj
Sent: Wednesday, April 09, 2014 11:49 PM
To: [email protected]
Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value
Quoted 5 lines · Jie (Jackie)
Quoted 5 lines
-----Original Message-----
From: [email protected] [mailto:
openembedded-devel-
Quoted 5 lines
Quoted 5 lines
[email protected]] On Behalf Of Khem Raj
Sent: Wednesday, April 09, 2014 4:13 PM
To: [email protected]
Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value
Quoted 8 lines
Quoted 8 lines · On Apr 8, 2014 8:27 PM, <[email protected]> wrote:
Quoted 5 lines
From: Jackie Huang <[email protected]>
Remove the unnecessary return(1) from function usage(), so that eject -h can return the right value.
this is an API change i wonder if other programs rely on the value
being >0
Quoted 1 line

Quoted 7 lines

Quoted 2 lines
I think the answer should be no, I don't see any reason to return 1 for
the "-h" or
Quoted 2 lines
"--help", almost all programs return 0 for that, right?
mostly yes and change is ok too just discuss it with package community and see if this is ok.

Yeah, sure, I will send it to the community, thanks!

Thanks,
Jackie

Quoted 73 lines

Quoted 20 lines
Thanks,
Jackie
Quoted 17 lines
Quoted 8 lines
Signed-off-by Zhangle Yang <[email protected]>
Signed-off-by Jackie Huang <[email protected]>
---
 .../eject/eject/eject-2.1.5-error-return.patch     |   10 ++++++++++
 meta-oe/recipes-support/eject/eject_2.1.5.bb       |    4 +++-
 2 files changed, 13 insertions(+), 1 deletion(-)  create mode
100644
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 2 lines
diff --git
a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 4 lines
new file mode 100644
index 0000000..2cce3c3
--- /dev/null
+++
b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +3 -0
@@ -0,0 +1,10 @@
+Upstream-Status: Pending
+
+--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +7 -0
++++ eject/eject.c      2013-09-11 18:09:05.000000000 +0800
+@@ -207,7 +207,6 @@
+ "If omitted, name defaults to `%s'.\n"
+ "By default tries -r, -s, -f, and -q in order until success.\n"),
+                       DEFAULTDEVICE);
+-  exit(1);
+ }
diff --git
a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-support/eject/
Quoted 29 lines
Quoted 24 lines
eject_2.1.5.bb
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM =
Quoted 4 lines
index 98319a3..c47c653 100644
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -0
@@ -5,7 +5,9 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
Quoted 9 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +2 -1
 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \
+           file://eject-2.1.5-error-return.patch \ "
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] =
"ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"
Quoted 8 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -1
--
1.7.9.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Huang, Jie (Jackie)

author

2014-04-22 08:23 UTC #8 lore raw

Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value

Quoted 46 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Huang, Jie (Jackie)
Sent: Thursday, April 10, 2014 9:15 AM
To: [email protected]
Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value
Quoted 35 lines
-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Khem Raj
Sent: Wednesday, April 09, 2014 11:49 PM
To: [email protected]
Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value
Quoted 5 lines · Jie (Jackie)
Quoted 5 lines
-----Original Message-----
From: [email protected] [mailto:
openembedded-devel-
Quoted 6 lines
Quoted 6 lines
[email protected]] On Behalf Of Khem Raj
Sent: Wednesday, April 09, 2014 4:13 PM
To: [email protected]
Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value
Quoted 8 lines
Quoted 8 lines · On Apr 8, 2014 8:27 PM, <[email protected]> wrote:
Quoted 5 lines
From: Jackie Huang <[email protected]>
Remove the unnecessary return(1) from function usage(), so that eject -h can return the right value.
this is an API change i wonder if other programs rely on the value
being >0
Quoted 3 lines
I think the answer should be no, I don't see any reason to return 1 for

Quoted 7 lines

Quoted 5 lines
the "-h" or
Quoted 2 lines
"--help", almost all programs return 0 for that, right?
mostly yes and change is ok too just discuss it with package community and see if this is ok.
Yeah, sure, I will send it to the community, thanks!

The latest update on the upstream is 6 years ago:
http://eject.cvs.sourceforge.net/viewvc/eject/eject/eject/

and the mailing list is no longer available.

So I will update the Upstream-Status and send v2 for this.

Thanks,
Jackie

Quoted 87 lines

Thanks,
Jackie
Quoted 72 lines
Quoted 22 lines
Thanks,
Jackie
Quoted 19 lines
Quoted 8 lines
Signed-off-by Zhangle Yang <[email protected]>
Signed-off-by Jackie Huang <[email protected]>
---
 .../eject/eject/eject-2.1.5-error-return.patch     |   10 ++++++++++
 meta-oe/recipes-support/eject/eject_2.1.5.bb       |    4 +++-
 2 files changed, 13 insertions(+), 1 deletion(-)  create mode
100644
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 2 lines
diff --git
a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.pat ch b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.pat ch
Quoted 4 lines
new file mode 100644
index 0000000..2cce3c3
--- /dev/null
+++
b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +3 -0
@@ -0,0 +1,10 @@
+Upstream-Status: Pending
+
+--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file +7 -0
++++ eject/eject.c      2013-09-11 18:09:05.000000000 +0800
+@@ -207,7 +207,6 @@
+ "If omitted, name defaults to `%s'.\n"
+ "By default tries -r, -s, -f, and -q in order until success.\n"),
+                       DEFAULTDEVICE);
+-  exit(1);
+ }
diff --git
a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-suppor t/eject/
Quoted 30 lines
Quoted 25 lines
eject_2.1.5.bb
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM =
Quoted 4 lines
index 98319a3..c47c653 100644
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -0
@@ -5,7 +5,9 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
meta-oe/recipes-support/eject/eject_2.1.5.bb LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
Quoted 9 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +2 -1
 inherit autotools gettext update-alternatives
 
-SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz"
+SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \
+           file://eject-2.1.5-error-return.patch \ "
 
 SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738"
 SRC_URI[sha256sum] =
"ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55"
Quoted 9 lines
meta-oe/recipes-support/eject/eject_2.1.5.bb +0 -1
--
1.7.9.5
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-deve
l
Quoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel