Skip to contentSkip to conversation

Makefile: toolchain-eclipse-register: add toolchain dependency

PATCH New Fabio Porcedda 2 participants 4 messages Apr 18, 2014 – Apr 20, 2014 Kbuild

lore
Share & tools
lore

Fabio Porcedda

author
#0 lore raw

PATCH 1/2 Makefile: toolchain-eclipse-register: add toolchain dependency

The "toolchain-eclipse-register" target needs the toolchain so add toolchain as a dependency.
This also fix the support to top-level parallel make.

Signed-off-by Fabio Porcedda <[email protected]>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 42adf7c..53282ae 100644
@@ -621,7 +621,7 @@ target-post-image: $(TARGETS_ROOTFS) target-finalize
 		$(call MESSAGE,"Executing post-image script $(s)"); \
 		$(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep))
 
-toolchain-eclipse-register:
+toolchain-eclipse-register: toolchain
 	./support/scripts/eclipse-register-toolchain `readlink -f $(O)` $(notdir $(TARGET_CROSS)) $(BR2_ARCH)
 
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)
Signature · 1 line
1.9.2
author
#1 lore raw

PATCH 2/2 Makefile: target-generatelocales: add toolchain dependency

The target depends on the toolchain so add it as a dependency. This also fix the support to top-level parallel make.

Signed-off-by Fabio Porcedda <[email protected]>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 53282ae..e204038 100644
@@ -598,7 +598,7 @@ ifneq ($(GENERATE_LOCALE),)
 # data comes preferably from the toolchain, or if the toolchain does
 # not have them (Linaro toolchains), we use the ones available on the
 # host machine.
-target-generatelocales: host-localedef
+target-generatelocales: host-localedef toolchain
 	$(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
 	$(Q)for locale in $(GENERATE_LOCALE) ; do \
 		inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
Signature · 1 line
1.9.2
author
#2 lore raw

PATCH 2/2 Makefile: target-generatelocales: add toolchain dependency

Quoted 22 lines · Fabio Porcedda

The target depends on the toolchain so add it as a dependency. This also fix the support to top-level parallel make.

Signed-off-by Fabio Porcedda <[email protected]>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index 53282ae..e204038 100644
@@ -598,7 +598,7 @@ ifneq ($(GENERATE_LOCALE),)
 # data comes preferably from the toolchain, or if the toolchain does
 # not have them (Linaro toolchains), we use the ones available on the
 # host machine.
-target-generatelocales: host-localedef
+target-generatelocales: host-localedef toolchain
        $(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
        $(Q)for locale in $(GENERATE_LOCALE) ; do \
                inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
--
Quoted 2 lines

1.9.2

I've done like that because i think that the "target-generatelocales" depends only on the toolchain target, doesn't it?

Regards

Signature · 1 line
Fabio Porcedda
#3 lore raw

PATCH 1/2 Makefile: toolchain-eclipse-register: add toolchain dependency

In reply to Fabio Porcedda

Dear Fabio Porcedda,

Quoted 8 lines · Fabio Porcedda

The "toolchain-eclipse-register" target needs the toolchain so add toolchain as a dependency.
This also fix the support to top-level parallel make.

Signed-off-by Fabio Porcedda <[email protected]>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Both patches applied.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com