Skip to contentSkip to conversation

update sunxi-boards and sunxi-tools for pcDuino board

PATCH New Brian Beattie 2 participants 3 messages Dec 11, 2013 – Apr 20, 2014

lore
Share & tools
lore
#0 lore raw

cover update sunxi-boards and sunxi-tools for pcDuino board

In preparation for adding support for for the pcduino board, update the sunxi-boards and sunxi-tools to the commit recommended for pcduino.

These packages are also used by the Cubieboard so if somebody with a Cubieboard could test this that would be good.

Brian Beattie (2):
update sunxi-boards to newer commit as recomended for pcDuino board update sunxi-boards to newer commit as recomended for pcDuino board

 package/sunxi-boards/sunxi-boards.mk | 2 +-
 package/sunxi-tools/sunxi-tools.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 9 lines
1.8.1.2


-- 
"For every complex problem there is an answer that is clear, simple, and
wrong." -- H. L. Mencken

Brian Beattie<[email protected]> -- www.brian-beattie.com
LFS12947
#1 lore raw

cover update sunxi-boards and sunxi-tools for pcDuino board

Dear Brian Beattie,

Quoted 9 lines · Brian Beattie

In preparation for adding support for for the pcduino board, update the sunxi-boards and sunxi-tools to the commit recommended for pcduino.

These packages are also used by the Cubieboard so if somebody with a Cubieboard could test this that would be good.

Brian Beattie (2):
update sunxi-boards to newer commit as recomended for pcDuino board update sunxi-boards to newer commit as recomended for pcDuino board

Thanks for your patches! They look good, except for a few minor things:

* Their title should be something like:

<package name>: <what is happening to them>

so typically:

sunxi-boards: bump version, to support the pcDuino board
sunxi-tools: bump version, to support the pcDuino board

* The title of your second patch was wrong: it bumps the version of sunxi-tools, not sunxi-boards.

* You should sent your patches with 'git send-email'. You've sent them with Evolution, but Evolution has line-wrapped the patches, which prevents them from being applied. Also, it will ensure that your patches are sent as replies to your cover letter, all automatically.

* Your patches should have a Signed-off-by line.

See
http://buildroot.org/downloads/manual/manual.html#_contributing_to_buildroot
for more details.

Could you resend a version 2 of your patch series with these minor issues fixed?

Also, since you're using the pcDuino board, could you submit a simple defconfig that builds a minimal system for this platform (i.e toolchain
+ bootloader + kernel + minimal rootfs) ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

cover update sunxi-boards and sunxi-tools for pcDuino board

In reply to Brian Beattie

Dear Brian Beattie,

Quoted 9 lines · Brian Beattie

In preparation for adding support for for the pcduino board, update the sunxi-boards and sunxi-tools to the commit recommended for pcduino.

These packages are also used by the Cubieboard so if somebody with a Cubieboard could test this that would be good.

Brian Beattie (2):
update sunxi-boards to newer commit as recomended for pcDuino board update sunxi-boards to newer commit as recomended for pcDuino board

I've applied your two patches. However, note that they were line-wrapped, the title of the second patch was wrong (it was updating the sunxi-tools package), and the commit logs were both lacking your Signed-off-by line.

Thanks for your contribution!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com