Skip to contentSkip to conversation

sunxi-mali: add missing GLchar definitions.

PATCH New Eric Le Bihan 3 participants 3 messages Apr 21, 2014 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi-mali: add missing GLchar definitions.

The GLES and GLES2 header files provided by sunxi-mali do not define the type "GLchar" and use "char" instead in the prototype of some functions.

In order to have some applications build (like cairo), a new patch has been added to define the missing type.

This issue has been reported upstream some time ago, but the pull request has not been merged yet.
(See https://github.com/linux-sunxi/sunxi-mali/pull/8).

Fixes http://autobuild.buildroot.net/results/2cb/2cb13a5bb92dabed219d49f49f0b9a2dfe65a0ca/.

---
 ...-mali-0001-Add-missing-GLchar-definitions.patch | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/sunxi-mali/sunxi-mali-0001-Add-missing-GLchar-definitions.patch
package/sunxi-mali/sunxi-mali-0001-Add-missing-GLchar-definitions.patch new file +38 -0
new file mode 100644
index 0000000..50bd7f9
@@ -0,0 +1,38 @@
+From 058d5e8cd90d117535b5d314fd9e15c70028ff20 Mon Sep 17 00:00:00 2001
+From: Eric Le Bihan <[email protected]>
+Date: Mon, 21 Apr 2014 19:31:23 +0200
+Subject: [PATCH] Add missing GLchar definitions.
+
+Signed-off-by: Eric Le Bihan <[email protected]>
+---
+ include/GLES/gl.h   | 1 +
+ include/GLES2/gl2.h | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/include/GLES/gl.h b/include/GLES/gl.h
+index 858f394..a6bb591 100644
+--- a/include/GLES/gl.h
++++ b/include/GLES/gl.h
+@@ -29,6 +29,7 @@ typedef float  GLfloat;
+ typedef float  GLclampf;
+ typedef signed int  GLfixed;
+ typedef signed int  GLclampx;
++typedef char GLchar;
+ 
+ typedef int * GLintptr;
+ typedef int *  GLsizeiptr;
+diff --git a/include/GLES2/gl2.h b/include/GLES2/gl2.h
+index 59e376c..90d96bb 100644
+--- a/include/GLES2/gl2.h
++++ b/include/GLES2/gl2.h
+@@ -32,6 +32,7 @@ typedef unsigned int     GLuint;
+ typedef khronos_float_t  GLfloat;
+ typedef khronos_float_t  GLclampf;
+ typedef khronos_int32_t  GLfixed;
++typedef char             GLchar;
+ 
+ /* GL types for handling large vertex buffer objects */
+ typedef khronos_intptr_t GLintptr;
+-- 
+1.9.0
+
Signature · 1 line
1.9.0
#1 lore raw

PATCH 1/1 sunxi-mali: add missing GLchar definitions.

Eric,All,

On 2014-04-21 19:49 +0200, Eric Le Bihan spake thusly:

Quoted 6 lines

The GLES and GLES2 header files provided by sunxi-mali do not define the type "GLchar" and use "char" instead in the prototype of some functions.

In order to have some applications build (like cairo), a new patch has been added to define the missing type.

Quoted 7 lines

This issue has been reported upstream some time ago, but the pull request has not been merged yet.
(See https://github.com/linux-sunxi/sunxi-mali/pull/8).

Fixes http://autobuild.buildroot.net/results/2cb/2cb13a5bb92dabed219d49f49f0b9a2dfe65a0ca/.

Regards,
Yann E. MORIN.

Quoted 56 lines
---
 ...-mali-0001-Add-missing-GLchar-definitions.patch | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/sunxi-mali/sunxi-mali-0001-Add-missing-GLchar-definitions.patch
package/sunxi-mali/sunxi-mali-0001-Add-missing-GLchar-definitions.patch new file +38 -0
new file mode 100644
index 0000000..50bd7f9
@@ -0,0 +1,38 @@
+From 058d5e8cd90d117535b5d314fd9e15c70028ff20 Mon Sep 17 00:00:00 2001
+From: Eric Le Bihan <[email protected]>
+Date: Mon, 21 Apr 2014 19:31:23 +0200
+Subject: [PATCH] Add missing GLchar definitions.
+
+Signed-off-by: Eric Le Bihan <[email protected]>
+---
+ include/GLES/gl.h   | 1 +
+ include/GLES2/gl2.h | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/include/GLES/gl.h b/include/GLES/gl.h
+index 858f394..a6bb591 100644
+--- a/include/GLES/gl.h
++++ b/include/GLES/gl.h
+@@ -29,6 +29,7 @@ typedef float  GLfloat;
+ typedef float  GLclampf;
+ typedef signed int  GLfixed;
+ typedef signed int  GLclampx;
++typedef char GLchar;
+ 
+ typedef int * GLintptr;
+ typedef int *  GLsizeiptr;
+diff --git a/include/GLES2/gl2.h b/include/GLES2/gl2.h
+index 59e376c..90d96bb 100644
+--- a/include/GLES2/gl2.h
++++ b/include/GLES2/gl2.h
+@@ -32,6 +32,7 @@ typedef unsigned int     GLuint;
+ typedef khronos_float_t  GLfloat;
+ typedef khronos_float_t  GLclampf;
+ typedef khronos_int32_t  GLfixed;
++typedef char             GLchar;
+ 
+ /* GL types for handling large vertex buffer objects */
+ typedef khronos_intptr_t GLintptr;
+-- 
+1.9.0
+
Signature · 6 lines
1.9.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 sunxi-mali: add missing GLchar definitions.

In reply to Eric Le Bihan

Dear Eric Le Bihan,

Quoted 10 lines · Eric Le Bihan

The GLES and GLES2 header files provided by sunxi-mali do not define the type "GLchar" and use "char" instead in the prototype of some functions.

In order to have some applications build (like cairo), a new patch has been added to define the missing type.

This issue has been reported upstream some time ago, but the pull request has not been merged yet.
(See https://github.com/linux-sunxi/sunxi-mali/pull/8).

Quoted 7 lines

Fixes http://autobuild.buildroot.net/results/2cb/2cb13a5bb92dabed219d49f49f0b9a2dfe65a0ca/.

---
 ...-mali-0001-Add-missing-GLchar-definitions.patch | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/sunxi-mali/sunxi-mali-0001-Add-missing-GLchar-definitions.patch

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com