xfstests: add helper for zero range support check
PATCH 1/3 xfstests: add helper for zero range support check
Add a helper function to verify fallocate zero range support in a style similar to _require_xfs_io_falloc_collapse(), etc.
--- common/rc | 7 +++++++ 1 file changed, 7 insertions(+)
common/rc +7 -0
@@ -1375,6 +1375,13 @@ _require_xfs_io_falloc_collapse() _require_xfs_io_command "fcollapse" } +# check that xfs_io, kernel, and filesystem all support fallocate with zero +# range +_require_xfs_io_falloc_zero() +{ + _require_xfs_io_command "fzero" +} + # check that xfs_io, kernel and filesystem support fiemap _require_xfs_io_fiemap() {
Signature · 6 lines
1.8.3.2 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
common/rc _require_xfs_io_falloc_collapse() · line 1383
Quoted 6 lines
common/rc +6
-0+# check that xfs_io, kernel, and filesystem all support fallocate with zero +# range +_require_xfs_io_falloc_zero() +{ + _require_xfs_io_command "fzero" +}
I'd rather remove all the wrappers around _require_xfs_io_command, they don't actually add any value.
Quoted 9 lines · Christoph Hellwig
common/rc _require_xfs_io_falloc_collapse() · line 1383
Quoted 6 lines
common/rc +6
-0+# check that xfs_io, kernel, and filesystem all support fallocate with zero +# range +_require_xfs_io_falloc_zero() +{ + _require_xfs_io_command "fzero" +}I'd rather remove all the wrappers around
_require_xfs_io_command, they don't actually add any value.
I don't really care either way, as long as all the checks are done consistently. Send a patch to change them all... :)
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 2 lines · Dave Chinner
I don't really care either way, as long as all the checks are done consistently. Send a patch to change them all... :)
My flink test already avoids the wrapper :)
So how about we stop adding them for now at least.
Quoted 7 lines · Christoph Hellwig
Date: Tue, 22 Apr 2014 02:16:20 -0700
From: Christoph Hellwig <[email protected]>
To: Dave Chinner <[email protected]>
Cc: Christoph Hellwig <[email protected]>, [email protected],
[email protected], Eric Whitney <[email protected]>
Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
Quoted 7 lines
Quoted 2 lines · Dave Chinner
I don't really care either way, as long as all the checks are done consistently. Send a patch to change them all... :)
My flink test already avoids the wrapper :)
So how about we stop adding them for now at least.
I agree,
even though I screwed up when using _require_xfs_io_command with fzero :) I think that we can avoid the wrappers and just use _require_xfs_io_command() with the command name.
-Lukas
Quoted 6 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 15 lines · Lukáš Czerner
Quoted 13 lines · Christoph Hellwig
Date: Tue, 22 Apr 2014 02:16:20 -0700
From: Christoph Hellwig <[email protected]>
To: Dave Chinner <[email protected]>
Cc: Christoph Hellwig <[email protected]>, [email protected],
[email protected], Eric Whitney <[email protected]>
Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support checkQuoted 2 lines · Dave Chinner
I don't really care either way, as long as all the checks are done consistently. Send a patch to change them all... :)
My flink test already avoids the wrapper :)
Quoted 7 lines
Quoted 1 line
So how about we stop adding them for now at least.
I agree,
even though I screwed up when using
_require_xfs_io_commandwith fzero :) I think that we can avoid the wrappers and just use_require_xfs_io_command()with the command name.
Send patches ;)
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs