Skip to contentSkip to conversation

tty/serial: atmel_serial: Fix device tree documentation

PATCH RESEND Superseded Richard Genoud 2 participants 4 messages Apr 18, 2014 – Apr 22, 2014

Subsystems (3)
Device tree bindings TTY layer and serial drivers Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Richard Genoud

author
#0 lore raw

PATCH RESEND 1/1 tty/serial: atmel_serial: Fix device tree documentation

RTS pin is an active low pin.
For now, this doesn't change anything as the ACTIVE_LOW (1) flag is not handled in atmel_serial, but it will be in 3.16.

Signed-off-by Richard Genoud <[email protected]>
---
 Documentation/devicetree/bindings/serial/atmel-usart.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/atmel-usart.txt +1 -1
index 17c1042b2df8..0dd0a5493a54 100644
@@ -35,7 +35,7 @@ Example:
 		clock-names = "usart";
 		atmel,use-dma-rx;
 		atmel,use-dma-tx;
-		rts-gpios = <&pioD 15 0>;
+		rts-gpios = <&pioD 15 1>;
 	};
 
 - use DMA:
Signature · 1 line
1.8.5.5
author
#1 lore raw

PATCH RESEND 1/1 tty/serial: atmel_serial: Fix device tree documentation

2014-04-18 17:45 GMT+02:00 Richard Genoud <[email protected]>:

Quoted 14 lines

RTS pin is an active low pin.
For now, this doesn't change anything as the ACTIVE_LOW (1) flag is not handled in atmel_serial, but it will be in 3.16.

Signed-off-by Richard Genoud <[email protected]>
---
 Documentation/devicetree/bindings/serial/atmel-usart.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/atmel-usart.txt +0 -0
index 17c1042b2df8..0dd0a5493a54 100644

Documentation/devicetree/bindings/serial/atmel-usart.txt Example: · line 41

Quoted 8 lines
Documentation/devicetree/bindings/serial/atmel-usart.txt +1 -1
@@ -35,7 +35,7 @@ Example:
                clock-names = "usart";
                atmel,use-dma-rx;
                atmel,use-dma-tx;
-               rts-gpios = <&pioD 15 0>;
+               rts-gpios = <&pioD 15 1>;
        };
 
 - use DMA:

Rob,
Does this has a chance to get to 3.15-rc3 or it's not worth it ? If it's not programmed for the 3.15-rc cycle, please drop it : I've got a patchset depending on it, and it will be in another tree.

Richard.

#2 lore raw

PATCH RESEND 1/1 tty/serial: atmel_serial: Fix device tree documentation

Hi,

Quoted 22 lines · Richard Genoud

2014-04-18 17:45 GMT+02:00 Richard Genoud <[email protected]>:

Quoted 21 lines

RTS pin is an active low pin.
For now, this doesn't change anything as the ACTIVE_LOW (1) flag is not handled in atmel_serial, but it will be in 3.16.

Signed-off-by Richard Genoud <[email protected]>
---
 Documentation/devicetree/bindings/serial/atmel-usart.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/atmel-usart.txt +1 -1
index 17c1042b2df8..0dd0a5493a54 100644
@@ -35,7 +35,7 @@ Example:
                clock-names = "usart";
                atmel,use-dma-rx;
                atmel,use-dma-tx;
-               rts-gpios = <&pioD 15 0>;
+               rts-gpios = <&pioD 15 1>;
        };
Quoted 7 lines

Documentation/devicetree/bindings/serial/atmel-usart.txt Example: · line 41

Quoted 1 line
Documentation/devicetree/bindings/serial/atmel-usart.txt +0 -0
 - use DMA:

Rob,
Does this has a chance to get to 3.15-rc3 or it's not worth it ? If it's not programmed for the 3.15-rc cycle, please drop it : I've got a patchset depending on it, and it will be in another tree.

I would say that kind of change should go through Nicolas' tree or gregkh tty tree as it is directly related to the driver.

Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH RESEND 1/1 tty/serial: atmel_serial: Fix device tree documentation

2014-04-22 16:37 GMT+02:00 Alexandre Belloni
<[email protected]>:

Quoted 33 lines

Hi,

Quoted 22 lines · Richard Genoud

2014-04-18 17:45 GMT+02:00 Richard Genoud <[email protected]>:

Quoted 21 lines

RTS pin is an active low pin.
For now, this doesn't change anything as the ACTIVE_LOW (1) flag is not handled in atmel_serial, but it will be in 3.16.

Signed-off-by Richard Genoud <[email protected]>
---
 Documentation/devicetree/bindings/serial/atmel-usart.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/atmel-usart.txt +1 -1
index 17c1042b2df8..0dd0a5493a54 100644
@@ -35,7 +35,7 @@ Example:
                clock-names = "usart";
                atmel,use-dma-rx;
                atmel,use-dma-tx;
-               rts-gpios = <&pioD 15 0>;
+               rts-gpios = <&pioD 15 1>;
        };
Quoted 7 lines

Documentation/devicetree/bindings/serial/atmel-usart.txt Example: · line 41

Quoted 1 line
Documentation/devicetree/bindings/serial/atmel-usart.txt +0 -0
 - use DMA:

Rob,
Does this has a chance to get to 3.15-rc3 or it's not worth it ? If it's not programmed for the 3.15-rc cycle, please drop it : I've got a patchset depending on it, and it will be in another tree.

Quoted 2 lines

I would say that kind of change should go through Nicolas' tree or gregkh tty tree as it is directly related to the driver.

Ok, I'll send it to greg, since my patchset is on the tty tree.

thanks !