iommu/amd: Fix interrupt remapping for aliased devices
PATCH 1/1 iommu/amd: Fix interrupt remapping for aliased devices
An apparent cut and paste error prevents the correct flags from being set on the alias device resulting in MSI on conventional PCI devices failing to work. This also produces error events from the IOMMU like:
AMD-Vi: Event logged [INVALID_DEVICE_REQUEST device=00:14.4 address=0x000000fdf8000000 flags=0x0a00]
Where 14.4 is a PCIe-to-PCI bridge with a device behind it trying to use MSI interrupts.
--- drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd_iommu.c +1 -1
@@ -4004,7 +4004,7 @@ static struct irq_remap_table *get_irq_table(u16 devid, bool ioapic)iommu_flush_dte (iommu, devid);if (devid != alias) { irq_lookup_table[alias] = table; -set_dte_irq_entry (devid, table); +set_dte_irq_entry (alias, table);iommu_flush_dte (iommu, alias); }
Quoted 11 lines · Alex Williamson
An apparent cut and paste error prevents the correct flags from being set on the alias device resulting in MSI on conventional PCI devices failing to work. This also produces error events from the IOMMU like:
AMD-Vi: Event logged [
INVALID_DEVICE_REQUESTdevice=00:14.4 address=0x000000fdf8000000 flags=0x0a00]Where 14.4 is a PCIe-to-PCI bridge with a device behind it trying to use MSI interrupts.
Signed-off-by Alex Williamson <[email protected]>
Applied, thanks Alex.