autofs - fix lockref lookup
Ian Kent
maintainerPATCH 1/1 autofs - fix lockref lookup
autofs needs to be able to see private data dentry flags for its dentrys that are being created but not yet hashed and for its dentys that have been rmdir()ed but not yet freed. It needs to do this so it can block processes in these states until a status has been returned to indicate the given operation is complete.
It does this by keeping two lists, active and expring, of dentrys in this state and uses ->d_release() to keep them stable while it checks the reference count to determine if they should be used.
But with the recent lockref changes dentrys being freed sometimes don't transition to a reference count of 0 before being freed so autofs can occassionally use a dentry that is invalid which can lead to a panic.
--- fs/autofs4/root.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/autofs4/root.c +2 -2
@@ -179,7 +179,7 @@ static struct dentry *autofs4_lookup_active(struct dentry *dentry)spin_lock (&active->d_lock);/* Already gone? */ -if (!d_count (active)) +if ((int )d_count (active) <=0 ) goto next; qstr = &active->d_name;
@@ -230,7 +230,7 @@ static struct dentry *autofs4_lookup_expiring(struct dentry *dentry)spin_lock (&expiring->d_lock); -/* Bad luck, we've already been dentry_iput */ +/* We've already been dentry_iput or unlinked */ if (!expiring->d_inode) goto next;
Quoted 12 lines · On Wed, 23 Apr 2014 13:20:36 +0800 Ian Kent <[email protected]> wrote:
autofs needs to be able to see private data dentry flags for its dentrys that are being created but not yet hashed and for its dentys that have been rmdir()ed but not yet freed. It needs to do this so it can block processes in these states until a status has been returned to indicate the given operation is complete.
It does this by keeping two lists, active and expring, of dentrys in this state and uses ->d_release() to keep them stable while it checks the reference count to determine if they should be used.
Quoted 4 lines
But with the recent lockref changes dentrys being freed sometimes don't transition to a reference count of 0 before being freed so autofs can occassionally use a dentry that is invalid which can lead to a panic.
What's the value of "recent"? I assume 3.14 is OK?
Ian Kent
maintainerQuoted 14 lines · Andrew Morton
Quoted 12 lines · On Wed, 23 Apr 2014 13:20:36 +0800 Ian Kent <[email protected]> wrote:
autofs needs to be able to see private data dentry flags for its dentrys that are being created but not yet hashed and for its dentys that have been rmdir()ed but not yet freed. It needs to do this so it can block processes in these states until a status has been returned to indicate the given operation is complete.
It does this by keeping two lists, active and expring, of dentrys in this state and uses ->d_release() to keep them stable while it checks the reference count to determine if they should be used.
Quoted 6 lines
Quoted 4 lines
But with the recent lockref changes dentrys being freed sometimes don't transition to a reference count of 0 before being freed so autofs can occassionally use a dentry that is invalid which can lead to a panic.
What's the value of "recent"? I assume 3.14 is OK?
I'll need to look again but from memory it's broken from 3.12 onward.
The breakage happened when lockref_mark_dead() was introduced because it sets lockref->count = -128 instead of reducing count by one as was done previously.
Ian