ARM: dts: am335x: update USB DT references

RFC PATCH New Leigh Brown 4 participants 7 messages Apr 16, 2014 – Apr 23, 2014 Device tree bindings

Share & tools

Leigh Brown

author

2014-04-16 11:26 UTC #0 lore raw

RFC PATCH 1/1 ARM: dts: am335x: update USB DT references

In "ARM: dts: am33xx: correcting dt node unit address for usb", the usb_ctrl_mod and cppi41dma nodes were updated with the correct register addresses. However, the dts files that reference these nodes were not updated, and those devices are no longer being enabled.

This patch corrects the references for the affected dts files.

Signed-off-by Leigh Brown <[email protected]>

---
 arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
 arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
 arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
 arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

arch/arm/boot/dts/am335x-bone-common.dtsi +2 -2

index e3f27ec..2e7d932 100644
@@ -183,7 +183,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -204,7 +204,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

arch/arm/boot/dts/am335x-evm.dts +2 -2

index 28ae040..77df10d 100644
@@ -331,7 +331,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -352,7 +352,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

arch/arm/boot/dts/am335x-evmsk.dts +2 -2

index ec08f6f..ab23885 100644
@@ -364,7 +364,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -385,7 +385,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

arch/arm/boot/dts/am335x-igep0033.dtsi +2 -2

index 7063311..5942e7d 100644
@@ -202,7 +202,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -223,7 +223,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

Signature · 1 line

1.9.1

Benoit Cousson

2014-04-22 14:14 UTC #1 lore raw

RFC PATCH 1/1 ARM: dts: am335x: update USB DT references

Hi Leigh,

Quoted 6 lines · Leigh Brown

In "ARM: dts: am33xx: correcting dt node unit address for usb", the usb_ctrl_mod and cppi41dma nodes were updated with the correct register addresses. However, the dts files that reference these nodes were not updated, and those devices are no longer being enabled.
This patch corrects the references for the affected dts files.

Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated version?

FYI, even with this fix, the BBB still does not have a working MUSB on 3.15-rc2. Have you observed that as well?

Quoted 1 line

Signed-off-by Leigh Brown <[email protected]>

If this is a final version, I'll apply it for -rc3.

Thanks,
Benoit

Quoted 96 lines

---
  arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
  arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
  arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
  arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
  4 files changed, 8 insertions(+), 8 deletions(-)

arch/arm/boot/dts/am335x-bone-common.dtsi +2 -2

index e3f27ec..2e7d932 100644
@@ -183,7 +183,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

@@ -204,7 +204,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

arch/arm/boot/dts/am335x-evm.dts +2 -2

index 28ae040..77df10d 100644
@@ -331,7 +331,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

@@ -352,7 +352,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

arch/arm/boot/dts/am335x-evmsk.dts +2 -2

index ec08f6f..ab23885 100644
@@ -364,7 +364,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

@@ -385,7 +385,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

arch/arm/boot/dts/am335x-igep0033.dtsi +2 -2

index 7063311..5942e7d 100644
@@ -202,7 +202,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

@@ -223,7 +223,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

Signature · 4 lines

Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com

Tony Lindgren

2014-04-23 14:48 UTC #2 lore raw

RFC PATCH 1/1 ARM: dts: am335x: update USB DT references

Quoted 13 lines · Benoit Cousson

Hi Leigh,
Quoted 6 lines · Leigh Brown
In "ARM: dts: am33xx: correcting dt node unit address for usb", the usb_ctrl_mod and cppi41dma nodes were updated with the correct register addresses. However, the dts files that reference these nodes were not updated, and those devices are no longer being enabled.
This patch corrects the references for the affected dts files.
Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated version?

Quoted 6 lines

FYI, even with this fix, the BBB still does not have a working MUSB on 3.15-rc2. Have you observed that as well?
Quoted 1 line
Signed-off-by Leigh Brown <[email protected]>
If this is a final version, I'll apply it for -rc3.

Looks like I already have this in omap-for-v3.15/fixes-v2, sorry looks like I never replied to this one.

Regards,

Tony

Quoted 103 lines

Quoted 96 lines

---
 arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
 arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
 arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
 arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

arch/arm/boot/dts/am335x-bone-common.dtsi +2 -2

index e3f27ec..2e7d932 100644
@@ -183,7 +183,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -204,7 +204,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

arch/arm/boot/dts/am335x-evm.dts +2 -2

index 28ae040..77df10d 100644
@@ -331,7 +331,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -352,7 +352,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

arch/arm/boot/dts/am335x-evmsk.dts +2 -2

index ec08f6f..ab23885 100644
@@ -364,7 +364,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -385,7 +385,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

arch/arm/boot/dts/am335x-igep0033.dtsi +2 -2

index 7063311..5942e7d 100644
@@ -202,7 +202,7 @@
 &usb {
 	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
 		status = "okay";
 	};

@@ -223,7 +223,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
 		status = "okay";
 	};
 };

Signature · 4 lines

Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com

Ezequiel Garcia

2014-04-23 15:17 UTC #3 lore raw

RFC PATCH 1/1 ARM: dts: am335x: update USB DT references

Quoted 10 lines · Tony Lindgren

Quoted 9 lines · Benoit Cousson
Hi Leigh,
Quoted 6 lines · Leigh Brown
In "ARM: dts: am33xx: correcting dt node unit address for usb", the usb_ctrl_mod and cppi41dma nodes were updated with the correct register addresses. However, the dts files that reference these nodes were not updated, and those devices are no longer being enabled.
This patch corrects the references for the affected dts files.

Maybe someone can take care of using phandles instead?

This way, the board's dts files would be immune to such .dtsi changes.

Signature · 3 lines

Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

Benoit Cousson

2014-04-23 15:40 UTC #4 lore raw

RFC PATCH 1/1 ARM: dts: am335x: update USB DT references

Hi Ezequiel,

Quoted 10 lines · Ezequiel Garcia

Quoted 9 lines · Tony Lindgren
Quoted 8 lines · Benoit Cousson
Hi Leigh,
Quoted 5 lines · Leigh Brown
In "ARM: dts: am33xx: correcting dt node unit address for usb", the usb_ctrl_mod and cppi41dma nodes were updated with the correct register addresses. However, the dts files that reference these nodes were not updated, and those devices are no longer being enabled.

Quoted 5 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
This patch corrects the references for the affected dts files.
Maybe someone can take care of using phandles instead?
This way, the board's dts files would be immune to such .dtsi changes.

Indeed, that will avoid such issues.

Are you volunteer for that cleanup ? :-)

Thanks,
Benoit

Signature · 4 lines

Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com

Ezequiel Garcia

2014-04-23 15:48 UTC #5 lore raw

RFC PATCH 1/1 ARM: dts: am335x: update USB DT references

Quoted 15 lines · Benoit Cousson

Hi Ezequiel,
Quoted 12 lines · Ezequiel Garcia
Quoted 10 lines · Tony Lindgren
Quoted 9 lines · Benoit Cousson
Hi Leigh,
Quoted 6 lines · Leigh Brown
In "ARM: dts: am33xx: correcting dt node unit address for usb", the usb_ctrl_mod and cppi41dma nodes were updated with the correct register addresses. However, the dts files that reference these nodes were not updated, and those devices are no longer being enabled.
This patch corrects the references for the affected dts files.

Quoted 8 lines

Quoted 3 lines
Maybe someone can take care of using phandles instead?
This way, the board's dts files would be immune to such .dtsi changes.
Indeed, that will avoid such issues.
Are you volunteer for that cleanup ? :-)

Sure, I've already done that for my custom dts. It's a simple change.

If someone feels like doing this before I get to send the patches, be my guest :-)

Signature · 3 lines

Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

Benoit Cousson

2014-04-23 15:35 UTC #6 lore raw

RFC PATCH 1/1 ARM: dts: am335x: update USB DT references

In reply to Tony Lindgren

Hi Tony,

Quoted 17 lines · Tony Lindgren

Quoted 16 lines · Benoit Cousson
Hi Leigh,
Quoted 6 lines · Leigh Brown
In "ARM: dts: am33xx: correcting dt node unit address for usb", the usb_ctrl_mod and cppi41dma nodes were updated with the correct register addresses. However, the dts files that reference these nodes were not updated, and those devices are no longer being enabled.
This patch corrects the references for the affected dts files.
Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated version?
FYI, even with this fix, the BBB still does not have a working MUSB on 3.15-rc2. Have you observed that as well?

Quoted 6 lines

Quoted 3 lines
Quoted 1 line
Signed-off-by Leigh Brown <[email protected]>
If this is a final version, I'll apply it for -rc3.
Looks like I already have this in omap-for-v3.15/fixes-v2, sorry looks like I never replied to this one.

:-)

OK, I'll let you handle this one.

Thanks,
Benoit

Quoted 108 lines

Regards,

Tony

Quoted 103 lines

Quoted 88 lines

---
  arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
  arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
  arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
  arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
  4 files changed, 8 insertions(+), 8 deletions(-)

arch/arm/boot/dts/am335x-bone-common.dtsi +2 -2

index e3f27ec..2e7d932 100644
@@ -183,7 +183,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

@@ -204,7 +204,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

arch/arm/boot/dts/am335x-evm.dts +2 -2

index 28ae040..77df10d 100644
@@ -331,7 +331,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

@@ -352,7 +352,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

arch/arm/boot/dts/am335x-evmsk.dts +2 -2

index ec08f6f..ab23885 100644
@@ -364,7 +364,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

@@ -385,7 +385,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

arch/arm/boot/dts/am335x-igep0033.dtsi +1 -1

index 7063311..5942e7d 100644
@@ -202,7 +202,7 @@
  &usb {
  	status = "okay";
 
-	control at 44e10000 {
+	control at 44e10620 {
  		status = "okay";
  	};

arch/arm/boot/dts/am335x-igep0033.dtsi line 229

Quoted 8 lines

arch/arm/boot/dts/am335x-igep0033.dtsi +1 -1

@@ -223,7 +223,7 @@
  		dr_mode = "host";
  	};
 
-	dma-controller at 07402000  {
+	dma-controller at 47402000  {
  		status = "okay";
  	};
  };

--
Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com

Signature · 4 lines

Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com