nfsd bug fixes for 3.15

DISCUSSION J. Bruce Fields 2 participants 6 messages Apr 24, 2014 – Apr 25, 2014

Subsystems (3)

VFS NFS client NFS server

lore

Share & tools

lore

J. Bruce Fields

author

2014-04-24 06:25 UTC #0 lore raw

Please pull the following bug fixes for 3.15 from:

git://linux-nfs.org/~bfields/linux.git for-3.15

Three small nfsd bugfixes (including one locks.c fix for a bug triggered only from nfsd).

Jeff's patches are for long-existing problems that became easier to trigger since the addition of vfs delegation support.

--b.

----------------------------------------------------------------
J. Bruce Fields (1):
Revert "nfsd4: fix nfs4err_resource in 4.1 case"

Jeff Layton (2):
locks: allow __break_lease to sleep even when break_time is 0
nfsd: set timeparms.to_maxval in setup_callback_client

 fs/locks.c             | 7 +++----
 fs/nfsd/nfs4callback.c | 4 +++-
 fs/nfsd/nfs4xdr.c      | 8 --------
 3 files changed, 6 insertions(+), 13 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Trond Myklebust

2014-04-24 10:51 UTC #1 lore raw

Hi Bruce,

Quoted 7 lines · J. Bruce Fields

Please pull the following bug fixes for 3.15 from:
git://linux-nfs.org/~bfields/linux.git for-3.15
Three small nfsd bugfixes (including one locks.c fix for a bug triggered only from nfsd).

Quoted 9 lines

Jeff's patches are for long-existing problems that became easier to trigger since the addition of vfs delegation support.
--b.
----------------------------------------------------------------
J. Bruce Fields (1):
Revert "nfsd4: fix nfs4err_resource in 4.1 case"

Wait. Why? NFS4ERR_RESOURCE breaks the Linux client.

Signature · 5 lines

Trond Myklebust

Linux NFS client maintainer, PrimaryData

[email protected]

J. Bruce Fields

author

2014-04-24 15:31 UTC #2 lore raw

Quoted 13 lines · Trond Myklebust

Hi Bruce,
Quoted 10 lines · J. Bruce Fields
Please pull the following bug fixes for 3.15 from:
git://linux-nfs.org/~bfields/linux.git for-3.15
Three small nfsd bugfixes (including one locks.c fix for a bug triggered only from nfsd).
Jeff's patches are for long-existing problems that became easier to trigger since the addition of vfs delegation support.

Quoted 8 lines

Quoted 6 lines
--b.
----------------------------------------------------------------
J. Bruce Fields (1):
Revert "nfsd4: fix nfs4err_resource in 4.1 case"
Wait. Why?

Have you changed your mind since our previous discussion, or just forgotten it? (Or did I screw up and revert the wrong commit?) See

	http://mid.gmane.org/<[email protected]>

Quoted 1 line

NFS4ERR_RESOURCE breaks the Linux client.

This returns us to pre-3.15 behavior so shouldn't introduce any new breakage.

Fundamentally the problem is that we're returning an error in cases that shouldn't succeed, and rather than replacing one incorrect error by another it seemed better to wait for a proper fix.

--b.

J. Bruce Fields

author

2014-04-24 16:34 UTC #3 lore raw

Quoted 28 lines · J. Bruce Fields

Quoted 13 lines · Trond Myklebust
Hi Bruce,
Quoted 10 lines · J. Bruce Fields
Please pull the following bug fixes for 3.15 from:
git://linux-nfs.org/~bfields/linux.git for-3.15
Three small nfsd bugfixes (including one locks.c fix for a bug triggered only from nfsd).
Jeff's patches are for long-existing problems that became easier to trigger since the addition of vfs delegation support.
Quoted 8 lines
Quoted 6 lines
--b.
----------------------------------------------------------------
J. Bruce Fields (1):
Revert "nfsd4: fix nfs4err_resource in 4.1 case"
Wait. Why?
Have you changed your mind since our previous discussion, or just forgotten it? (Or did I screw up and revert the wrong commit?) See
	http://mid.gmane.org/<[email protected]>

Quoted 7 lines

Quoted 1 line
NFS4ERR_RESOURCE breaks the Linux client.
This returns us to pre-3.15 behavior so shouldn't introduce any new breakage.
Fundamentally the problem is that we're returning an error in cases that shouldn't succeed, and rather than replacing one incorrect error by

s/shouldn't/should/, apologies!--b.

Quoted 3 lines

another it seemed better to wait for a proper fix.
--b.

Trond Myklebust

2014-04-24 16:46 UTC #4 lore raw

Quoted 31 lines · J. Bruce Fields

Quoted 30 lines · J. Bruce Fields
Quoted 13 lines · Trond Myklebust
Hi Bruce,
Quoted 10 lines · J. Bruce Fields
Please pull the following bug fixes for 3.15 from:
git://linux-nfs.org/~bfields/linux.git for-3.15
Three small nfsd bugfixes (including one locks.c fix for a bug triggered only from nfsd).
Jeff's patches are for long-existing problems that became easier to trigger since the addition of vfs delegation support.
Quoted 8 lines
Quoted 6 lines
--b.
----------------------------------------------------------------
J. Bruce Fields (1):
Revert "nfsd4: fix nfs4err_resource in 4.1 case"
Wait. Why?
Have you changed your mind since our previous discussion, or just forgotten it? (Or did I screw up and revert the wrong commit?) See
      http://mid.gmane.org/<[email protected]>
Quoted 1 line
NFS4ERR_RESOURCE breaks the Linux client.

Quoted 11 lines

Quoted 5 lines
This returns us to pre-3.15 behavior so shouldn't introduce any new breakage.
Fundamentally the problem is that we're returning an error in cases that shouldn't succeed, and rather than replacing one incorrect error by
s/shouldn't/should/, apologies!--b.
Quoted 3 lines
another it seemed better to wait for a proper fix.
--b.

I really shouldn't try to read my email before 8am (or at least not before my third espresso). I was confusing this with the NFS4ERR_STALE_STATEID problem that was merged as part of the same pull.
Reverting the NFS4ERR_RESOURCE patch is fine.

Apologies,
Trond

Signature · 5 lines

Trond Myklebust

Linux NFS client maintainer, PrimaryData

[email protected]

J. Bruce Fields

author

2014-04-25 07:39 UTC #5 lore raw

Quoted 42 lines · Trond Myklebust

Quoted 41 lines · J. Bruce Fields
Quoted 28 lines · J. Bruce Fields
Quoted 13 lines · Trond Myklebust
Hi Bruce,
Quoted 10 lines · J. Bruce Fields
Please pull the following bug fixes for 3.15 from:
git://linux-nfs.org/~bfields/linux.git for-3.15
Three small nfsd bugfixes (including one locks.c fix for a bug triggered only from nfsd).
Jeff's patches are for long-existing problems that became easier to trigger since the addition of vfs delegation support.
Quoted 8 lines
Quoted 6 lines
--b.
----------------------------------------------------------------
J. Bruce Fields (1):
Revert "nfsd4: fix nfs4err_resource in 4.1 case"
Wait. Why?
Have you changed your mind since our previous discussion, or just forgotten it? (Or did I screw up and revert the wrong commit?) See
      http://mid.gmane.org/<[email protected]>
Quoted 7 lines
Quoted 1 line
NFS4ERR_RESOURCE breaks the Linux client.
This returns us to pre-3.15 behavior so shouldn't introduce any new breakage.
Fundamentally the problem is that we're returning an error in cases that shouldn't succeed, and rather than replacing one incorrect error by
s/shouldn't/should/, apologies!--b.
Quoted 2 lines
another it seemed better to wait for a proper fix.

Quoted 7 lines

Quoted 1 line
Quoted 1 line
--b.
I really shouldn't try to read my email before 8am (or at least not before my third espresso). I was confusing this with the NFS4ERR_STALE_STATEID problem that was merged as part of the same pull.
Reverting the NFS4ERR_RESOURCE patch is fine.

Great, thanks.--b.