smack: needs kernel headers v3.0+
PATCH 1/1 smack: needs kernel headers v3.0+
smack uses symbols that are exported to userspace only since Linux kernel commit 1dbe39424a43 (xattr.h: expose string defines to userspace).
Fixes:
http://autobuild.buildroot.net/results/7fc/7fc69002fbb37962e65e0f83384ae7a4e6eac8a9/
--- package/smack/Config.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
package/smack/Config.in +3 -1
@@ -1,6 +1,7 @@ config BR2_PACKAGE_SMACK bool "smack" depends on !BR2_PREFER_STATIC_LIB # dlfcn.h + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 help User space programs and libraries for SMACK.
@@ -28,5 +29,6 @@ config BR2_PACKAGE_SMACK https://github.com/smack-team/smack -comment "smack needs a toolchain w/ dynamic library" +comment "smack needs a toolchain w/ dynamic library, headers >= 3.0" depends on BR2_PREFER_STATIC_LIB + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
Signature · 1 line
1.9.2
Thomas Petazzoni
AppliedPATCH 1/1 smack: needs kernel headers v3.0+
Dear Baruch Siach,
Quoted 10 lines · Baruch Siach
smack uses symbols that are exported to userspace only since Linux kernel commit
1dbe39424a43(xattr.h: expose string defines to userspace).Fixes:
http://autobuild.buildroot.net/results/7fc/7fc69002fbb37962e65e0f83384ae7a4e6eac8a9/Signed-off-by Baruch Siach <[email protected]>--- package/smack/Config.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Applied... but I just realized there was a mistake:
package/smack/Config.in config BR2_PACKAGE_SMACK · line 34
Quoted 4 lines
package/smack/Config.in +2
-1-comment "smack needs a toolchain w/ dynamic library" +comment "smack needs a toolchain w/ dynamic library, headers >= 3.0" depends on BR2_PREFER_STATIC_LIB + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
This means the comment will only be displayed if both conditions are met (i.e static lib is enabled *and* we don't have at least 3.0 kernel headers). But we need the comment to be displayed if static lib is enabled *OR* we don't have at least 3.0 kernel headers.
Could you send a followup patch to fix this?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 smack: needs kernel headers v3.0+
Hi Thomas,
Quoted 24 lines · Thomas Petazzoni
Quoted 10 lines · Baruch Siach
smack uses symbols that are exported to userspace only since Linux kernel commit
1dbe39424a43(xattr.h: expose string defines to userspace).Fixes:
http://autobuild.buildroot.net/results/7fc/7fc69002fbb37962e65e0f83384ae7a4e6eac8a9/Signed-off-by Baruch Siach <[email protected]>--- package/smack/Config.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Applied... but I just realized there was a mistake:
package/smack/Config.in config BR2_PACKAGE_SMACK · line 34
Quoted 4 lines
package/smack/Config.in +2
-1-comment "smack needs a toolchain w/ dynamic library" +comment "smack needs a toolchain w/ dynamic library, headers >= 3.0" depends on BR2_PREFER_STATIC_LIB + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0This means the comment will only be displayed if both conditions are met (i.e static lib is enabled *and* we don't have at least 3.0 kernel headers). But we need the comment to be displayed if static lib is enabled *OR* we don't have at least 3.0 kernel headers.
Quoted 1 line
Could you send a followup patch to fix this?
Will send a fix shortly. Thanks for reviewing.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -