Skip to contentSkip to conversation

drm/tilcdc increase allowable supported resolution

PATCH In review Felipe Balbi 3 participants 4 messages Mar 3, 2014 – Apr 24, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tilcdc increase allowable supported resolution

From: Darren Etheridge <[email protected]>

1680x1050 appears to also be within the bandwidth capabilities of the device and memory infrastructure.

---
 drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tilcdc/tilcdc_drv.h +1 -1
index 5bb64e3..b47ec24 100644
@@ -43,7 +43,7 @@
  * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to
  * be supportable
  */
-#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1280*1024*60)
+#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1680*1050*60)
 
 
 struct tilcdc_drm_private {
Signature · 1 line
1.9.0
#1 lore raw
Quoted 6 lines · Felipe Balbi

From: Darren Etheridge <[email protected]>

1680x1050 appears to also be within the bandwidth capabilities of the device and memory infrastructure.

ping

Quoted 25 lines
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tilcdc/tilcdc_drv.h +1 -1
index 5bb64e3..b47ec24 100644
@@ -43,7 +43,7 @@
  * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to
  * be supportable
  */
-#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1280*1024*60)
+#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1680*1050*60)
 
 
 struct tilcdc_drm_private {
Signature · 7 lines
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Signature · 1 line
balbi
#2 lore raw
In reply to Felipe Balbi
Quoted 4 lines · Felipe Balbi

From: Darren Etheridge <[email protected]>

1680x1050 appears to also be within the bandwidth capabilities of the device and memory infrastructure.

For this one, is 1680x1050 possible on all devices w/ tilcdc (like 1st gen beaglebone (white), etc)? If not, maybe better to keep the default conservative and override the default in devicetree..

BR,
-R

Quoted 21 lines
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tilcdc/tilcdc_drv.h +1 -2
index 5bb64e3..b47ec24 100644
@@ -43,7 +43,7 @@
  * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to
  * be supportable
  */
-#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1280*1024*60)
+#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1680*1050*60)
 
 
 struct tilcdc_drm_private {
--

1.9.0

#3 lore raw

Rob Clark <[email protected]> wrote on Thu [2014-Apr-24 16:51:04 -0400]:

Quoted 10 lines · Felipe Balbi
Quoted 4 lines

From: Darren Etheridge <[email protected]>

1680x1050 appears to also be within the bandwidth capabilities of the device and memory infrastructure.

For this one, is 1680x1050 possible on all devices w/ tilcdc (like 1st gen beaglebone (white), etc)? If not, maybe better to keep the default conservative and override the default in devicetree..

Fair point Rob, I didn't test BeagleBone White at that resolution, only BeagleBone Black. I'll redo this patch as a BBB specific dts change given we already have a max-bandwidth DT binding in place for tilcdc.

Thanks for reviewing it.

Darren

Quoted 24 lines

BR,
-R

Quoted 21 lines
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tilcdc/tilcdc_drv.h +1 -2
index 5bb64e3..b47ec24 100644
@@ -43,7 +43,7 @@
  * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to
  * be supportable
  */
-#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1280*1024*60)
+#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1680*1050*60)
 
 
 struct tilcdc_drm_private {
--

1.9.0