Skip to contentSkip to conversation

dfu:fix: Replace wrong return value with proper one

PATCH New Lukasz Majewski 2 participants 2 messages Apr 24, 2014

lore
Share & tools
lore

Lukasz Majewski

author
#0 lore raw

PATCH 1/1 dfu:fix: Replace wrong return value with proper one

This patch remove always false (since we tested ret = 0) ternary operator with ret value returned.

Signed-off-by Lukasz Majewski <[email protected]>
---
 drivers/dfu/dfu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dfu/dfu.c +1 -1
index a41195b..422cdba 100644
@@ -238,7 +238,7 @@ int dfu_write(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num)
 			ret = tret;
 	}
 
-	return ret = 0 ? size : ret;
+	return ret;
 }
 
 static int dfu_read_buffer_fill(struct dfu_entity *dfu, void *buf, int size)
Signature · 1 line
1.7.10.4
Applied
#1 lore raw

PATCH 1/1 dfu:fix: Replace wrong return value with proper one

Quoted 7 lines · Lukasz Majewski

This patch remove always false (since we tested ret = 0) ternary operator with ret value returned.

Signed-off-by Lukasz Majewski <[email protected]>
---
 drivers/dfu/dfu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Best regards,
Marek Vasut