Skip to contentSkip to conversation

ARM: dts: omap3-igep0020: use SMSC9221 timings

PATCH New Javier Martinez Canillas 2 participants 2 messages Apr 24, 2014 – Apr 25, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: omap3-igep0020: use SMSC9221 timings

The IGEPv2 board has a SMSC LAN9221i ethernet chip and not a SMSC LAN911x connected to the GPMC. Each chip needs different timings in order to operate correctly so is wrong to include omap-gpmc-smsc911x.dtsi instead of omap-gpmc-smsc9221.dtsi.

---

Hi Tony,

I see no performance difference when measuring network throughput using iperf(1) but this change is the correct one nonetheless since if we later better adjust the timings it will already include the right dtsi.

Best regards,
Javier

 arch/arm/boot/dts/omap3-igep.dtsi    | 2 +-
 arch/arm/boot/dts/omap3-igep0020.dts | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap3-igep.dtsi +1 -1
index b97736d..e2d163b 100644
@@ -107,7 +107,7 @@
 		>;
 	};
 
-	smsc911x_pins: pinmux_smsc911x_pins {
+	smsc9221_pins: pinmux_smsc9221_pins {
 		pinctrl-single,pins = <
 			0x1a2 (PIN_INPUT | MUX_MODE4)		/* mcspi1_cs2.gpio_176 */
 		>;
arch/arm/boot/dts/omap3-igep0020.dts +2 -2
index 7abd64f..b22caaa 100644
@@ -10,7 +10,7 @@
  */
 
 #include "omap3-igep.dtsi"
-#include "omap-gpmc-smsc911x.dtsi"
+#include "omap-gpmc-smsc9221.dtsi"
 
 / {
 	model = "IGEPv2 (TI OMAP AM/DM37x)";
@@ -248,7 +248,7 @@
 
 	ethernet at gpmc {
 		pinctrl-names = "default";
-		pinctrl-0 = <&smsc911x_pins>;
+		pinctrl-0 = <&smsc9221_pins>;
 		reg = <5 0 0xff>;
 		interrupt-parent = <&gpio6>;
 		interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: omap3-igep0020: use SMSC9221 timings

Quoted 5 lines · Javier Martinez Canillas

The IGEPv2 board has a SMSC LAN9221i ethernet chip and not a SMSC LAN911x connected to the GPMC. Each chip needs different timings in order to operate correctly so is wrong to include omap-gpmc-smsc911x.dtsi instead of omap-gpmc-smsc9221.dtsi.

Quoted 8 lines

---

Hi Tony,

I see no performance difference when measuring network throughput using iperf(1) but this change is the correct one nonetheless since if we later better adjust the timings it will already include the right dtsi.

Yes, let's fix this as wrong timings can cause memory corruption. Applying into omap-for-v3.15/fixes-v2.

Tony