Skip to contentSkip to conversation

ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled

PATCH New Ezequiel Garcia 2 participants 6 messages Apr 24, 2014 – Apr 26, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Ezequiel Garcia

author
#0 lore raw

PATCH 1/1 ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled

HAVE_ARM_TWD depends on SMP, so we should only select it if SMP is enabled, as the others platforms do.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 arch/arm/mach-mvebu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mvebu/Kconfig +2 -2
index 7bb92b1..8c9fd60 100644
@@ -41,7 +41,7 @@ config MACH_ARMADA_375
 	select ARMADA_375_CLK
 	select CPU_V7
 	select HAVE_ARM_SCU
-	select HAVE_ARM_TWD
+	select HAVE_ARM_TWD if SMP
 	select HAVE_SMP
 	select MACH_MVEBU_V7
 	select PINCTRL_ARMADA_375

@@ -57,7 +57,7 @@ config MACH_ARMADA_38X
 	select ARMADA_38X_CLK
 	select CPU_V7
 	select HAVE_ARM_SCU
-	select HAVE_ARM_TWD
+	select HAVE_ARM_TWD if SMP
 	select HAVE_SMP
 	select MACH_MVEBU_V7
 	select PINCTRL_ARMADA_38X
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled

Jason,

Quoted 33 lines · Ezequiel Garcia

HAVE_ARM_TWD depends on SMP, so we should only select it if SMP is enabled, as the others platforms do.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 arch/arm/mach-mvebu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mvebu/Kconfig +2 -2
index 7bb92b1..8c9fd60 100644
@@ -41,7 +41,7 @@ config MACH_ARMADA_375
 	select ARMADA_375_CLK
 	select CPU_V7
 	select HAVE_ARM_SCU
-	select HAVE_ARM_TWD
+	select HAVE_ARM_TWD if SMP
 	select HAVE_SMP
 	select MACH_MVEBU_V7
 	select PINCTRL_ARMADA_375

@@ -57,7 +57,7 @@ config MACH_ARMADA_38X
 	select ARMADA_38X_CLK
 	select CPU_V7
 	select HAVE_ARM_SCU
-	select HAVE_ARM_TWD
+	select HAVE_ARM_TWD if SMP
 	select HAVE_SMP
 	select MACH_MVEBU_V7
 	select PINCTRL_ARMADA_38X
Signature · 1 line
1.9.1

As pointed out by Thomas, this fixes a build break when SMP=n. Maybe you can merge it sooner than later?

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled

In reply to Ezequiel Garcia
Quoted 7 lines · Ezequiel Garcia

HAVE_ARM_TWD depends on SMP, so we should only select it if SMP is enabled, as the others platforms do.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 arch/arm/mach-mvebu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I just tried to apply this against mvebu/fixes. It failed. What did you base this against?

Can you resubmit based against mvebu/fixes so I can queue it up for v3.15-rcX ?

thx,

Jason.

Quoted 30 lines
arch/arm/mach-mvebu/Kconfig +2 -2
index 7bb92b1..8c9fd60 100644
@@ -41,7 +41,7 @@ config MACH_ARMADA_375
 	select ARMADA_375_CLK
 	select CPU_V7
 	select HAVE_ARM_SCU
-	select HAVE_ARM_TWD
+	select HAVE_ARM_TWD if SMP
 	select HAVE_SMP
 	select MACH_MVEBU_V7
 	select PINCTRL_ARMADA_375

@@ -57,7 +57,7 @@ config MACH_ARMADA_38X
 	select ARMADA_38X_CLK
 	select CPU_V7
 	select HAVE_ARM_SCU
-	select HAVE_ARM_TWD
+	select HAVE_ARM_TWD if SMP
 	select HAVE_SMP
 	select MACH_MVEBU_V7
 	select PINCTRL_ARMADA_38X
Signature · 7 lines
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author
#3 lore raw

PATCH 1/1 ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled

Quoted 4 lines · Jason Cooper
Quoted 3 lines · Ezequiel Garcia

HAVE_ARM_TWD depends on SMP, so we should only select it if SMP is enabled, as the others platforms do.

Quoted 8 lines
Quoted 4 lines
Signed-off-by Ezequiel Garcia <[email protected]>
---
 arch/arm/mach-mvebu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I just tried to apply this against mvebu/fixes. It failed. What did you base this against?

This is a fix for the recent SMP support that you've merged in mvebu/soc.

In particular, it fixes:

[PATCH v3 08/11] ARM: mvebu: add SMP support for Armada 375 and Armada 38x

Yeah, I know: I wasn't really clear in the commit log. Sorry about that.

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled

Quoted 10 lines · Ezequiel Garcia
Quoted 9 lines · Jason Cooper
Quoted 7 lines · Ezequiel Garcia

HAVE_ARM_TWD depends on SMP, so we should only select it if SMP is enabled, as the others platforms do.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 arch/arm/mach-mvebu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 3 lines

I just tried to apply this against mvebu/fixes. It failed. What did you base this against?

This is a fix for the recent SMP support that you've merged in mvebu/soc.

duh. Sorry, I was moving fast and just recalled that you wanted this in 'soon' which I thought meant for v3.15. No problem then.

thx,

Jason.

Applied
#5 lore raw

PATCH 1/1 ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled

In reply to Ezequiel Garcia
Quoted 7 lines · Ezequiel Garcia

HAVE_ARM_TWD depends on SMP, so we should only select it if SMP is enabled, as the others platforms do.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 arch/arm/mach-mvebu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to mvebu/soc

thx,

Jason.