Skip to contentSkip to conversation

Staging:keucr:scsiglue.c-no semicolon terminated

PATCH In review Paul McQuade 2 participants 2 messages Apr 8, 2014 – Apr 25, 2014 Staging

lore
Share & tools
lore

Paul McQuade

author
#0 lore raw

PATCH 2/2 Staging:keucr:scsiglue.c-no semicolon terminated

WARNING: do {} while (0) macros should not be semicolon terminated

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/staging/keucr/scsiglue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/keucr/scsiglue.c +1 -1
index ac3d34d..fce19a4 100644
@@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
 	do { \
 		if (us->fflags & value) \
 			SPRINTF(" " #name); \
-	} while (0);
+	} while (0)
 US_DO_ALL_FLAGS
 #undef US_FLAG
 	seq_putc(m, '\n');
Signature · 1 line
1.8.3.2
maintainer
#1 lore raw
Quoted 12 lines · Paul McQuade

WARNING: do {} while (0) macros should not be semicolon terminated

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/staging/keucr/scsiglue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/keucr/scsiglue.c +0 -0
index ac3d34d..fce19a4 100644

drivers/staging/keucr/scsiglue.c static int show_info(struct seq_file *m, struct Scsi_Host *host) · line 283

Quoted 8 lines
drivers/staging/keucr/scsiglue.c +1 -1
@@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
 	do { \
 		if (us->fflags & value) \
 			SPRINTF(" " #name); \
-	} while (0);
+	} while (0)
 US_DO_ALL_FLAGS
 #undef US_FLAG
 	seq_putc(m, '\n');

Why would you send a patch that you obviously have not at least compile tested?

Hint, this breaks the build :(

ALWAYS test build your patches, to not do so is rude to others, don't you agree?

greg k-h