staging: silicom: Remove needless calls of get_status_port_fn()
PATCH 1/1 staging: silicom: Remove needless calls of get_status_port_fn()
Remove a needless pointer initialisation and call to get_status_port_fn() in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable 'pbpctl_dev_b' is set correctly later in the function before first use.
Signed-off-by Christian Engelmayer <[email protected]>
---
Compile tested and applies against v3.15-rc2 as well as branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
--- drivers/staging/silicom/bpctl_mod.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/staging/silicom/bpctl_mod.c +2 -5
@@ -4735,10 +4735,9 @@ static void bp_tpl_timer_fn(unsigned long param)static void remove_bypass_tpl_auto (struct bpctl_dev *pbpctl_dev) { -struct bpctl_dev *pbpctl_dev_b =NULL ; +struct bpctl_dev *pbpctl_dev_b;if (!pbpctl_dev)return ; - pbpctl_dev_b =get_status_port_fn (pbpctl_dev);if (pbpctl_dev->bp_caps &TPL_CAP ) {del_timer_sync (&pbpctl_dev->bp_tpl_timer);
@@ -4785,12 +4784,10 @@ static int set_bypass_tpl_auto(struct bpctl_dev *pbpctl_dev, unsigned int param)static int set_tpl_fn (struct bpctl_dev *pbpctl_dev,int tpl_mode) { -struct bpctl_dev *pbpctl_dev_b =NULL ; +struct bpctl_dev *pbpctl_dev_b;if (!pbpctl_dev)return -1 ; - pbpctl_dev_b =get_status_port_fn (pbpctl_dev); -if (pbpctl_dev->bp_caps &TPL_CAP ) {if (tpl_mode) { pbpctl_dev_b =get_status_port_fn (pbpctl_dev);
Signature · 1 line
1.9.1