Skip to contentSkip to conversation

ARM: dts: imx6qdl-wandboard: Move FEC reset pin into the FEC pin group

PATCH New Fabio Estevam 2 participants 2 messages Apr 23, 2014 – Apr 29, 2014

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx6qdl-wandboard: Move FEC reset pin into the FEC pin group

From: Fabio Estevam <[email protected]>

Remove GPIO3_29 (FEC PHY reset pin) from the hog group and place it into pinctrl_enet pin group instead.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-wandboard.dtsi +1 -1
index 5c6f10c..79498ca 100644
@@ -104,7 +104,6 @@
 				MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x80000000 /* WL_REG_ON */
 				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 /* WL_HOST_WAKE */
 				MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* WL_WAKE */
-				MX6QDL_PAD_EIM_D29__GPIO3_IO29   0x80000000
 			>;
 		};
 

@@ -136,6 +135,7 @@
 				MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL	0x1b0b0
 				MX6QDL_PAD_GPIO_16__ENET_REF_CLK	0x4001b0a8
 				MX6QDL_PAD_GPIO_6__ENET_IRQ		0x000b1
+				MX6QDL_PAD_EIM_D29__GPIO3_IO29   	0x80000000
 			>;
 		};
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 ARM: dts: imx6qdl-wandboard: Move FEC reset pin into the FEC pin group

Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Remove GPIO3_29 (FEC PHY reset pin) from the hog group and place it into pinctrl_enet pin group instead.

If you can clean up the pinctrl settings to kill hog group completely for the board, I would be happy to take the patch. Otherwise, let's leave it there for now, until you see a real problem with having the pin in hog group than pinctrl_enet.

Shawn

Quoted 31 lines
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-wandboard.dtsi +1 -1
index 5c6f10c..79498ca 100644
@@ -104,7 +104,6 @@
 				MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x80000000 /* WL_REG_ON */
 				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 /* WL_HOST_WAKE */
 				MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* WL_WAKE */
-				MX6QDL_PAD_EIM_D29__GPIO3_IO29   0x80000000
 			>;
 		};
 

@@ -136,6 +135,7 @@
 				MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL	0x1b0b0
 				MX6QDL_PAD_GPIO_16__ENET_REF_CLK	0x4001b0a8
 				MX6QDL_PAD_GPIO_6__ENET_IRQ		0x000b1
+				MX6QDL_PAD_EIM_D29__GPIO3_IO29   	0x80000000
 			>;
 		};
Signature · 1 line
1.8.3.2