Skip to contentSkip to conversation

xlib_libXpm: needs MMU (fork)

PATCH New Bernd Kuhls 3 participants 3 messages Apr 29, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xlib_libXpm: needs MMU (fork)

Fixes http://autobuild.buildroot.net/results/c57/c571b0a9d9f36a445ea36a4bd609154f9a9bddd5/

---
v2: extend patch to reverse dependency of xlib_libXpm (Thomas)

 package/x11r7/xlib_libXaw/Config.in |    1 +
 package/x11r7/xlib_libXpm/Config.in |    1 +
 2 files changed, 2 insertions(+)
package/x11r7/xlib_libXaw/Config.in +1 -0
index 3695bb6..12addc4 100644
@@ -5,5 +5,6 @@ config BR2_PACKAGE_XLIB_LIBXAW
 	select BR2_PACKAGE_XLIB_LIBXMU
 	select BR2_PACKAGE_XLIB_LIBXPM
 	select BR2_PACKAGE_XPROTO_XPROTO
+	depends on BR2_USE_MMU # fork() / xlib_libXpm
 	help
 	  X.Org Xaw library
package/x11r7/xlib_libXpm/Config.in +1 -0
index 528498c..077041a 100644
@@ -4,5 +4,6 @@ config BR2_PACKAGE_XLIB_LIBXPM
 	select BR2_PACKAGE_XLIB_LIBXEXT
 	select BR2_PACKAGE_XLIB_LIBXT
 	select BR2_PACKAGE_XPROTO_XPROTO
+	depends on BR2_USE_MMU # fork()
 	help
 	  X.Org Xpm library
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v2 1/1 xlib_libXpm: needs MMU (fork)

Hi Bernd,

Quoted 5 lines · Bernd Kuhls

Fixes http://autobuild.buildroot.net/results/c57/c571b0a9d9f36a445ea36a4bd609154f9a9bddd5/

---
v2: extend patch to reverse dependency of xlib_libXpm (Thomas)

The xvkbd package also selects BR2_PACKAGE_XLIB_LIBXPM.

Quoted 11 lines
 package/x11r7/xlib_libXaw/Config.in |    1 +
 package/x11r7/xlib_libXpm/Config.in |    1 +
 2 files changed, 2 insertions(+)
package/x11r7/xlib_libXaw/Config.in +0 -0
index 3695bb6..12addc4 100644

package/x11r7/xlib_libXaw/Config.in config BR2_PACKAGE_XLIB_LIBXAW · line 8

Quoted 4 lines
package/x11r7/xlib_libXaw/Config.in +1 -0
@@ -5,5 +5,6 @@ config BR2_PACKAGE_XLIB_LIBXAW
 	select BR2_PACKAGE_XLIB_LIBXMU
 	select BR2_PACKAGE_XLIB_LIBXPM
 	select BR2_PACKAGE_XPROTO_XPROTO
+	depends on BR2_USE_MMU # fork() / xlib_libXpm

This dependency should be propagated further recursively. Many packages select BR2_PACKAGE_XLIB_LIBXAW and all of them must also depend on BR2_USE_MMU.

Quoted 14 lines
package/x11r7/xlib_libXaw/Config.in +0 -0
 	help
 	  X.Org Xaw library
package/x11r7/xlib_libXpm/Config.in +1 -0
index 528498c..077041a 100644
@@ -4,5 +4,6 @@ config BR2_PACKAGE_XLIB_LIBXPM
 	select BR2_PACKAGE_XLIB_LIBXEXT
 	select BR2_PACKAGE_XLIB_LIBXT
 	select BR2_PACKAGE_XPROTO_XPROTO
+	depends on BR2_USE_MMU # fork()
 	help
 	  X.Org Xpm library
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH v2 1/1 xlib_libXpm: needs MMU (fork)

Dear Baruch Siach,

Quoted 2 lines · Baruch Siach

This dependency should be propagated further recursively. Many packages select BR2_PACKAGE_XLIB_LIBXAW and all of them must also depend on BR2_USE_MMU.

Maybe we should take a step back and see if libXpm could be fixed to not use fork() at all, or use vfork().

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com