serial: sh-sci: Add device tree support for r8a7779

PATCH Superseded Simon Horman 3 participants 3 messages Apr 29, 2014 – Apr 30, 2014

Subsystems (3)

Device tree bindings TTY layer and serial drivers SuperH

lore

Share & tools

lore

Simon Horman

author

2014-04-29 07:20 UTC #0 lore raw

PATCH v2 1/1 serial: sh-sci: Add device tree support for r8a7779

Simply document a new compat string.
There appears to be no need for a driver updates.

Signed-off-by Simon Horman <[email protected]>

---

v2
* Do not update the driver to set SCSCR_CKE1.
Instead DT may provide the P clock as the clock for the SCIF devices.

---
 Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 1 +
 1 file changed, 1 insertion(+)

Documentation/devicetree/bindings/serial/renesas,sci-serial.txt +1 -0

index 53e6c17..bba86de 100644
@@ -12,6 +12,7 @@ Required properties:
     - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
     - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
     - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
+    - "renesas,scif-r8a7779" for R8A7779 (R-Car H1) SCIF compatible UART.
     - "renesas,scif" for generic SCIF compatible UART.
     - "renesas,scifa" for generic SCIFA compatible UART.
     - "renesas,scifb" for generic SCIFB compatible UART.

Signature · 1 line

1.8.5.2

Laurent Pinchart

2014-04-30 01:06 UTC #1 lore raw

PATCH v2 1/1 serial: sh-sci: Add device tree support for r8a7779

Hi Simon,

Thank you for the patch.

I've CC'ed the DT list which seems to have been forgotten.

Quoted 20 lines · On Tuesday 29 April 2014 16:20:11 Simon Horman wrote:

Simply document a new compat string.
There appears to be no need for a driver updates.
Signed-off-by Simon Horman <[email protected]>
---
v2
* Do not update the driver to set SCSCR_CKE1.
Instead DT may provide the P clock as the clock for the SCIF devices.
---
 Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0
b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt index 53e6c17..bba86de 100644

Documentation/devicetree/bindings/serial/renesas,sci-serial.txt Required properties: · line 15

Quoted 4 lines

Documentation/devicetree/bindings/serial/renesas,sci-serial.txt +1 -0

@@ -12,6 +12,7 @@ Required properties:
     - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
     - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
     - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
+    - "renesas,scif-r8a7779" for R8A7779 (R-Car H1) SCIF compatible UART.

What about moving this at the top of the list to keep it sorted by SoC number ?

Apart from that,

Acked-by Laurent Pinchart <[email protected]>

Quoted 3 lines

Documentation/devicetree/bindings/serial/renesas,sci-serial.txt +0 -0

     - "renesas,scif" for generic SCIF compatible UART.
     - "renesas,scifa" for generic SCIFA compatible UART.
     - "renesas,scifb" for generic SCIFB compatible UART.

Signature · 3 lines

Regards,

Laurent Pinchart

Simon Horman

2014-04-30 01:44 UTC #2 lore raw

PATCH v2 1/1 serial: sh-sci: Add device tree support for r8a7779

Quoted 21 lines · Laurent Pinchart

Hi Simon,
Thank you for the patch.
I've CC'ed the DT list which seems to have been forgotten.
Quoted 14 lines · On Tuesday 29 April 2014 16:20:11 Simon Horman wrote:
Simply document a new compat string.
There appears to be no need for a driver updates.
Signed-off-by Simon Horman <[email protected]>
---
v2
* Do not update the driver to set SCSCR_CKE1.
Instead DT may provide the P clock as the clock for the SCIF devices.
---
 Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 1 +
 1 file changed, 1 insertion(+)

Quoted 13 lines

Documentation/devicetree/bindings/serial/renesas,sci-serial.txt Required properties: · line 15
Quoted 10 lines
(quoted diff) +0 -0
b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt index 53e6c17..bba86de 100644
Documentation/devicetree/bindings/serial/renesas,sci-serial.txt +1 -0
@@ -12,6 +12,7 @@ Required properties:
     - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
     - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
     - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
+    - "renesas,scif-r8a7779" for R8A7779 (R-Car H1) SCIF compatible UART.
What about moving this at the top of the list to keep it sorted by SoC number ?

Sure, will do.

Quoted 14 lines

Apart from that,
Acked-by Laurent Pinchart <[email protected]>
Quoted 3 lines
Documentation/devicetree/bindings/serial/renesas,sci-serial.txt +0 -0
     - "renesas,scif" for generic SCIF compatible UART.
     - "renesas,scifa" for generic SCIFA compatible UART.
     - "renesas,scifb" for generic SCIFB compatible UART.
Signature · 3 lines
Regards,

Laurent Pinchart