Skip to contentSkip to conversation

zeromq: disable test using fork() when fork() is no available

PATCH New Samuel Martin 2 participants 3 messages May 2, 2014 – May 3, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zeromq: disable test using fork() when fork() is no available

zeromp's configure script correctly detects the fork availability, but unconditionally build all tests.

This patch just disables the piece of code using fork() in the given test. This avoids the autoreconf step of the package.

Fixes:
http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/

---
 ...le-code-using-fork-when-fork-is-not-avail.patch | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/zeromq/zeromq-0001-tests-disable-code-using-fork-when-fork-is-not-avail.patch
package/zeromq/zeromq-0001-tests-disable-code-using-fork-when-fork-is-not-avail.patch new file +32 -0
new file mode 100644
index 0000000..0c17b6a
@@ -0,0 +1,32 @@
+From 694440779ae41f46e01a1486cbe702982c29ef0e Mon Sep 17 00:00:00 2001
+From: Samuel Martin <[email protected]>
+Date: Fri, 2 May 2014 16:12:20 +0200
+Subject: [PATCH] tests: disable code using fork() when fork() is not available
+
+Signed-off-by: Samuel Martin <[email protected]>
+---
+ tests/test_fork.cpp | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/tests/test_fork.cpp b/tests/test_fork.cpp
+index 637b6e9..67bc957 100644
+--- a/tests/test_fork.cpp
++++ b/tests/test_fork.cpp
+@@ -35,6 +35,7 @@ int main (void)
+     int rc = zmq_bind (pull, address);
+     assert (rc == 0);
+ 
++#ifdef HAVE_FORK
+     int pid = fork ();
+     if (pid == 0) {
+         //  Child process
+@@ -77,5 +78,6 @@ int main (void)
+         }
+         exit (0);
+     }
++#endif
+     return 0;
+ }
+-- 
+1.9.2
+
Signature · 1 line
1.9.2
#1 lore raw

PATCH 1/1 zeromq: disable test using fork() when fork() is no available

Dear Samuel Martin,

Quoted 5 lines · Samuel Martin

zeromp's configure script correctly detects the fork availability, but unconditionally build all tests.

This patch just disables the piece of code using fork() in the given test. This avoids the autoreconf step of the package.

Huh, but then it completely breaks the test, no? Would it be better to find an upstreamable solution instead?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 zeromq: disable test using fork() when fork() is no available

Thomas,

Quoted 11 lines · Thomas Petazzoni

Dear Samuel Martin,

Quoted 5 lines · Samuel Martin

zeromp's configure script correctly detects the fork availability, but unconditionally build all tests.

This patch just disables the piece of code using fork() in the given test. This avoids the autoreconf step of the package.

Huh, but then it completely breaks the test, no? Would it be better to find an upstreamable solution instead?

I don't think so.
Zeromq code already uses "#ifdef HAVE_FORK ... #endif" to protect the section using fork; I just did the same in the test source (disabling most/all of this test, so it now has not real meaning when fork() is not available).

BTW, I've just come up with a proper solution just by hacking the autotools (<ironic>my favorite build-system! </ironic>), so I'll repost this fix shortly.

Regards,

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 1 line
Samuel