Skip to contentSkip to conversation

staging: rtl8723au: fix some confusing indenting

PATCH In review Dan Carpenter 2 participants 2 messages May 3, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723au: fix some confusing indenting

The break and the "unknown++" are at the same indent level so my static checker complains. The if statement should be indented more.

drivers/staging/rtl8723au/core/rtw_mlme_ext.c +2 -2
index eb7b98e..4ad80e7 100644
@@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
 		case WLAN_EID_ERP_INFO:
 		case WLAN_EID_EXT_SUPP_RATES:
 		case WLAN_EID_VENDOR_SPECIFIC:
-		if (rtw_validate_vendor_specific_ies(pos, elen))
-			unknown++;
+			if (rtw_validate_vendor_specific_ies(pos, elen))
+				unknown++;
 			break;
 		case WLAN_EID_RSN:
 		case WLAN_EID_PWR_CAPABILITY:
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

The break and the "unknown++" are at the same indent level so my static checker complains. The if statement should be indented more.

Urgh yes, that should be cleaned up!

Quoted 16 lines
drivers/staging/rtl8723au/core/rtw_mlme_ext.c +2 -2
index eb7b98e..4ad80e7 100644
@@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
 		case WLAN_EID_ERP_INFO:
 		case WLAN_EID_EXT_SUPP_RATES:
 		case WLAN_EID_VENDOR_SPECIFIC:
-		if (rtw_validate_vendor_specific_ies(pos, elen))
-			unknown++;
+			if (rtw_validate_vendor_specific_ies(pos, elen))
+				unknown++;
 			break;
 		case WLAN_EID_RSN:
 		case WLAN_EID_PWR_CAPABILITY: