agp: info leak in agpioc_info_wrap()

PATCH RESEND New Dan Carpenter 1 participant 1 message May 3, 2014

Subsystems (2)

Kernel janitors Agpgart driver

lore

Share & tools

lore

Dan Carpenter

author

2014-05-03 20:27 UTC #0 lore raw

PATCH RESEND 1/1 agp: info leak in agpioc_info_wrap()

On 64 bit systems the agp_info struct has a 4 byte hole between ->agp_mode and ->aper_base. We need to clear it to avoid disclosing stack information to userspace.

Signed-off-by Dan Carpenter <[email protected]>

---
I sent this before on 13 Apr 2013 and a reminder on 31 May 2013 so now I'm going to try sneak it in through the akpm tree.

drivers/char/agp/frontend.c +1 -0

index 8121b4c..b297033 100644
@@ -730,6 +730,7 @@ static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg)
 
 	agp_copy_info(agp_bridge, &kerninfo);
 
+	memset(&userinfo, 0, sizeof(userinfo));
 	userinfo.version.major = kerninfo.version.major;
 	userinfo.version.minor = kerninfo.version.minor;
 	userinfo.bridge_id = kerninfo.device->vendor |