Skip to contentSkip to conversation

czmq: needs MMU

PATCH New Baruch Siach 3 participants 4 messages May 5, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 czmq: needs MMU

Fixes:
http://autobuild.buildroot.net/results/6dd/6dd6954e5ab8c422070e53b0e616e1b1a821c626/

Also, remove the Blackfin toolchain dependencies as these are redundant now since Blackfin is a noMMU arch.

---
 package/czmq/Config.in | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
package/czmq/Config.in +2 -6
index 29333680fd61..fbdedd1bec2f 100644
@@ -1,22 +1,18 @@
 config BR2_PACKAGE_CZMQ
 	bool "czmq"
 	select BR2_PACKAGE_ZEROMQ
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP # zeromq
 	depends on BR2_INET_IPV6 # zeromq
 	depends on BR2_LARGEFILE # util-linux
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq
-	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
-	# support
-	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
-		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	help
 	  High-level C Binding for 0MQ
 
 	  http://czmq.zeromq.org/
 
 comment "czmq needs a toolchain w/ C++, IPv6, largefile, wchar, threads"
-	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
-		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
+	depends on BR2_USE_MMU
 	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_INET_IPV6 && BR2_LARGEFILE \
 		&& BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS)
Signature · 1 line
2.0.0.rc0
#1 lore raw

PATCH 1/1 czmq: needs MMU

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/6dd/6dd6954e5ab8c422070e53b0e616e1b1a821c626/

Also, remove the Blackfin toolchain dependencies as these are redundant now since Blackfin is a noMMU arch.

You forgot its reverse dependencies (filemq). Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 czmq: needs MMU

In reply to Baruch Siach

package/czmq/Config.in line 4

Quoted 4 lines · On Mon, 5 May 2014 06:58:03 +0300 Baruch Siach <[email protected]> wrote:

config BR2_PACKAGE_CZMQ

package/czmq/Config.in +1 -0
 	bool "czmq"
 	select BR2_PACKAGE_ZEROMQ
+	depends on BR2_USE_MMU # fork()

^ ^ ^ ^

Quoted 19 lines
package/czmq/Config.in +0 -3
 	depends on BR2_INSTALL_LIBSTDCPP # zeromq
 	depends on BR2_INET_IPV6 # zeromq
 	depends on BR2_LARGEFILE # util-linux
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq
-	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
-	# support
-	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2

&& \

package/czmq/Config.in +0 -1
-		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	help
 	  High-level C Binding for 0MQ
 
 	  http://czmq.zeromq.org/
 
 comment "czmq needs a toolchain w/ C++, IPv6, largefile, wchar,

threads"

(quoted diff) +0 -1
-	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2

&& \

Review

Quoted 2 lines
(quoted diff) +1 -1
-		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
+	depends on BR2_USE_MMU

^ ^ ^ ^

Quoted 3 lines

depends on !(BR2_INSTALL_LIBSTDCPP && BR2_INET_IPV6 &&
BR2_LARGEFILE \ && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS)

Shouldn't the option and the comment have opposite conditions? I.E: Either display the option or the comment?

Mike

#3 lore raw

PATCH 1/1 czmq: needs MMU

Hi Mike,

Quoted 32 lines · Mike Zick

package/czmq/Config.in line 4

Quoted 4 lines · On Mon, 5 May 2014 06:58:03 +0300 Baruch Siach <[email protected]> wrote:

config BR2_PACKAGE_CZMQ

package/czmq/Config.in +1 -0
 	bool "czmq"
 	select BR2_PACKAGE_ZEROMQ
+	depends on BR2_USE_MMU # fork()

^ ^ ^ ^

Quoted 19 lines
package/czmq/Config.in +0 -3
 	depends on BR2_INSTALL_LIBSTDCPP # zeromq
 	depends on BR2_INET_IPV6 # zeromq
 	depends on BR2_LARGEFILE # util-linux
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq
-	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
-	# support
-	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2

&& \

package/czmq/Config.in +0 -1
-		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	help
 	  High-level C Binding for 0MQ
 
 	  http://czmq.zeromq.org/
 
 comment "czmq needs a toolchain w/ C++, IPv6, largefile, wchar,

threads"

(quoted diff) +0 -1
-	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2

&& \

Review

Quoted 2 lines
(quoted diff) +1 -1
-		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
+	depends on BR2_USE_MMU

^ ^ ^ ^

Quoted 6 lines
Quoted 3 lines

depends on !(BR2_INSTALL_LIBSTDCPP && BR2_INET_IPV6 &&
BR2_LARGEFILE \ && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS)

Shouldn't the option and the comment have opposite conditions? I.E: Either display the option or the comment?

MMU is usually an attribute of the CPU architecture, and not a software configuration issue. In this case we don't show the software dependencies comment since the user can't do much about the CPU architecture of choice in the context of Buildroot. See
http://buildroot.net/downloads/manual/manual.html#_literal_config_in_literal_file,
under "Dependencies on target and toolchain options".

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -