Skip to contentSkip to conversation

qla2xxx: fix incorrect debug printk

PATCH Superseded Dan Carpenter 2 participants 4 messages May 3, 2014 – May 5, 2014

Subsystems (3)
SCSI Kernel janitors QLogic QLA2XXX FC-SCSI driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 qla2xxx: fix incorrect debug printk

There are missing curly braces here so it prints that the recovery failed even when it succeeded.

Signed-off-by Dan Carpenter <[email protected]>

---
static checker stuff. not tested.

drivers/scsi/qla2xxx/qla_os.c +2 -0
index afc8481..00754a2 100644
@@ -4913,12 +4913,13 @@ qla2x00_do_dpc(void *data)
 				if (qlafx00_reset_initialize(base_vha)) {
 					/* Failed. Abort isp later. */
 
+					    &base_vha->dpc_flags)) {
 						set_bit(ISP_UNRECOVERABLE,
 						    &base_vha->dpc_flags);
 						ql_dbg(ql_dbg_dpc, base_vha,
 						    0x4021,
 						    "Reset Recovery Failed\n");
+					}
 				}
 			}
author
#1 lore raw
Quoted 3 lines · Dan Carpenter

There are missing curly braces here so it prints that the recovery failed even when it succeeded.

That's strange. This patch got corrupted somehow. I will resend.

regards,
dan carpenter

author
#2 lore raw

PATCH v2 1/1 qla2xxx: fix incorrect debug printk

There are missing curly braces here so it prints that the recovery failed even when it succeeded.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: version 1 patch was corrupted in sending somehow.

drivers/scsi/qla2xxx/qla_os.c +2 -1
index afc8481..00754a2 100644
@@ -4913,12 +4913,13 @@ qla2x00_do_dpc(void *data)
 				if (qlafx00_reset_initialize(base_vha)) {
 					/* Failed. Abort isp later. */
 					if (!test_bit(UNLOADING,
-					    &base_vha->dpc_flags))
+					    &base_vha->dpc_flags)) {
 						set_bit(ISP_UNRECOVERABLE,
 						    &base_vha->dpc_flags);
 						ql_dbg(ql_dbg_dpc, base_vha,
 						    0x4021,
 						    "Reset Recovery Failed\n");
+					}
 				}
 			}
Reviewed-by Giridhar Malavali Acked-by on v2 1/1
#3 lore raw
Quoted 17 lines · Dan Carpenter

There are missing curly braces here so it prints that the recovery failed even when it succeeded.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: version 1 patch was corrupted in sending somehow.

drivers/scsi/qla2xxx/qla_os.c +0 -1
index afc8481..00754a2 100644
@@ -4913,12 +4913,13 @@ qla2x00_do_dpc(void *data)
 				if (qlafx00_reset_initialize(base_vha)) {
 					/* Failed. Abort isp later. */
 					if (!test_bit(UNLOADING,
-					    &base_vha->dpc_flags))

drivers/scsi/qla2xxx/qla_os.c qla2x00_do_dpc(void *data) · line 4925

Quoted 10 lines
drivers/scsi/qla2xxx/qla_os.c +2 -0
+					    &base_vha->dpc_flags)) {
 						set_bit(ISP_UNRECOVERABLE,
 						    &base_vha->dpc_flags);
 						ql_dbg(ql_dbg_dpc, base_vha,
 						    0x4021,
 						    "Reset Recovery Failed\n");
+					}
 				}
 			}

Looks good. Thanks.

Reviewed-by Giridhar Malavali <[email protected]>
Acked-by Chad Dupuis <[email protected]>