Skip to contentSkip to conversation

config: enable CMD_BMP when API+LCD is enabled

PATCH New Stephen Warren 3 participants 4 messages Apr 18, 2014 – May 5, 2014

lore
Share & tools
lore

Stephen Warren

author
#0 lore raw

PATCH 1/1 config: enable CMD_BMP when API+LCD is enabled

From: Stephen Warren <[email protected]>

When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.

Signed-off-by Stephen Warren <[email protected]>
---
 include/config_fallbacks.h | 4 ++++
 1 file changed, 4 insertions(+)
include/config_fallbacks.h +4 -0
index e6fb47be0bd7..b304a4103def 100644
@@ -71,6 +71,10 @@
 #define CONFIG_LIB_RAND
 #endif
 
+#if defined(CONFIG_API) && defined(CONFIG_LCD)
+#define CONFIG_CMD_BMP
+#endif
+
 #ifndef CONFIG_SYS_PROMPT
 #define CONFIG_SYS_PROMPT	"=> "
 #endif
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 config: enable CMD_BMP when API+LCD is enabled

Hi Stephen,

Quoted 10 lines · Stephen Warren

From: Stephen Warren <[email protected]>

When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.

Signed-off-by Stephen Warren <[email protected]>
Reviewed-by Simon Glass <[email protected]>

I do wonder whether it might be better to #error in this case?

Regards,
Simon

author
#2 lore raw

PATCH 1/1 config: enable CMD_BMP when API+LCD is enabled

Quoted 12 lines · Simon Glass

Hi Stephen,

Quoted 9 lines · Stephen Warren

From: Stephen Warren <[email protected]>

When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.

Quoted 5 lines
Quoted 1 line
Signed-off-by Stephen Warren <[email protected]>
Reviewed-by Simon Glass <[email protected]>

I do wonder whether it might be better to #error in this case?

I see it rather like a "select" in Kconfig. (although perhaps this would end up being a depends rather than a select)

#3 lore raw

PATCH 1/1 config: enable CMD_BMP when API+LCD is enabled

In reply to Stephen Warren
Quoted 8 lines · On Fri, 18 Apr 2014 11:15:55 -0600 Stephen Warren <[email protected]> wrote:

From: Stephen Warren <[email protected]>

When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.

Quoted 4 lines
Signed-off-by Stephen Warren <[email protected]>
---
 include/config_fallbacks.h | 4 ++++
 1 file changed, 4 insertions(+)

applied to u-boot-video/master. Thanks!

Anatolij