Skip to contentSkip to conversation

at91: video: atmel_hlcdfb.c: fix bad timing configuration

PATCH New Josh Wu 2 participants 2 messages Mar 10, 2014 – May 5, 2014

Subsystems (2)
Framebuffer layer Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Josh Wu

author
#0 lore raw

PATCH 1/1 at91: video: atmel_hlcdfb.c: fix bad timing configuration

The right correspondance between LCD margins and LCD timings is:
* upper margin -> vertical back porch
* lower margin -> vertical front porch
* left margin -> horizontal back porch
* right margin -> horizontal front porch

Signed-off-by Josh Wu <[email protected]>
---
 drivers/video/atmel_hlcdfb.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/video/atmel_hlcdfb.c +4 -4
index fc95897..e5d287d 100644
@@ -144,12 +144,12 @@ void lcd_ctrl_init(void *lcdbase)
 	value |= LCDC_LCDCFG1_HSPW(panel_info.vl_hsync_len - 1);
 	lcdc_writel(&regs->lcdc_lcdcfg1, value);
 
-	value = LCDC_LCDCFG2_VBPW(panel_info.vl_lower_margin);
-	value |= LCDC_LCDCFG2_VFPW(panel_info.vl_upper_margin - 1);
+	value = LCDC_LCDCFG2_VBPW(panel_info.vl_upper_margin);
+	value |= LCDC_LCDCFG2_VFPW(panel_info.vl_lower_margin - 1);
 	lcdc_writel(&regs->lcdc_lcdcfg2, value);
 
-	value = LCDC_LCDCFG3_HBPW(panel_info.vl_right_margin - 1);
-	value |= LCDC_LCDCFG3_HFPW(panel_info.vl_left_margin - 1);
+	value = LCDC_LCDCFG3_HBPW(panel_info.vl_left_margin - 1);
+	value |= LCDC_LCDCFG3_HFPW(panel_info.vl_right_margin - 1);
 	lcdc_writel(&regs->lcdc_lcdcfg3, value);
 
 	/* Display size */
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 at91: video: atmel_hlcdfb.c: fix bad timing configuration

Quoted 10 lines · On Mon, 10 Mar 2014 16:40:41 +0800 Josh Wu <[email protected]> wrote:

The right correspondance between LCD margins and LCD timings is:
* upper margin -> vertical back porch
* lower margin -> vertical front porch
* left margin -> horizontal back porch
* right margin -> horizontal front porch

Signed-off-by Josh Wu <[email protected]>
---
 drivers/video/atmel_hlcdfb.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

applied to u-boot-video/master. Thanks!

Anatolij